fix(gui): center the wizard + show returning users only the new feature (26.06.01)#68
Merged
Merged
Conversation
…ature (26.06.01) Fix a 26.06.00 regression where the setup wizard could open off-center, and stop showing existing users the whole first-run flow after an update. - onboarding_dialog.py: center the wizard over the main window on first show, falling back to the active screen when the parent is not yet mapped (the cause of the off-center open). - A returning user (re-onboarded after an ONBOARDING_VERSION bump) now sees ONLY the new feature's page, with its activation toggle, so they can review and enable it, instead of replaying welcome/privacy/browser/etc. New installs get the personalization opt-in as the LAST setup step. - Document the convention in CONTRIBUTING (bump ONBOARDING_VERSION + add the page when a feature adds an opt-in setting users should review), so future settings-bearing features surface to existing users at release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes two 26.06.00 wizard regressions and cuts patch 26.06.01.
ONBOARDING_VERSION, a returning user now sees only the new feature's page (with its activation toggle) so they can review and enable it, instead of replaying welcome/privacy/browser. New installs get the personalization opt-in as the last setup step.Also documents the convention in CONTRIBUTING: when a feature adds an opt-in setting users should review, add its wizard page and bump
ONBOARDING_VERSIONso it surfaces once to existing users.Tests
ruff+format+mypy+ 553 tests green, including a newtest_returning_user_sees_only_the_new_feature_page.🤖 Generated with Claude Code