feat(gui): sidebar settings nav + inline per-engine API keys (26.05.12)#64
Merged
Merged
Conversation
Settings dialog moves from top tabs to a left-hand navigation column, and the BYO API keys are entered inline on the Search engines page: each key-requiring engine has its password field + Save/Clear directly under its checkbox, disabled until the engine is checked. The standalone API keys section is removed. Key-requiring engines (Brave / Mojeek API / Kagi) now default to unchecked; the free engines stay on. is_engine_enabled resolves the per-engine default from requires_api_key, so both the checkbox state and the in-process engine builder agree. Also fixes a latent bug where saving/clearing the Kagi key updated Mojeek's status label, now that each engine owns its inline field and status. Bumps version to 26.05.12. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings dialog redesign, plus the release bump to 26.05.12.
Changes
QListWidget+QStackedWidget, styled#settingsNavfor light/dark).is_engine_enabledderives the per-engine default fromrequires_api_key, so the checkbox state and the in-process engine builder agree.Tests
Added: API-engine default-off helper assertions; sidebar-nav-has-no-API-keys-section; inline-key-field-grays-until-engine-checked. Full suite green (ruff + mypy + pytest, 525 tests). Rendered the dialog offscreen to verify layout in dark theme.
Note
Existing profiles that never explicitly toggled a key-requiring engine will see it flip to off under the new default; re-check it (with a key saved) to keep using it.
🤖 Generated with Claude Code