Remove old rolling viewpoint forecasting infrastructure#2075
Closed
Remove old rolling viewpoint forecasting infrastructure#2075
Conversation
Documentation build overview
Show files changed (6 files in total): 📝 6 modified | ➕ 0 added | ➖ 0 deleted
|
Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/0ca5a6ca-dff1-4438-a875-41c2b76a1495 Co-authored-by: BelhsanHmida <149331360+BelhsanHmida@users.noreply.github.com>
Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/0ca5a6ca-dff1-4438-a875-41c2b76a1495 Co-authored-by: BelhsanHmida <149331360+BelhsanHmida@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove old rolling forecasting code after fixed-point migration
Remove old rolling viewpoint forecasting infrastructure
Mar 31, 2026
8 tasks
Contributor
|
closed replaced by #2082 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codebase retained rolling viewpoint forecasting infrastructure after the migration to fixed-point forecasting: a
NotImplementedErrorstub, the working-but-misnamedmake_rolling_viewpoint_forecasts, an overly restrictive horizon allowlist (supported_horizons), and its orphanedInvalidHorizonException.Changes
data/services/forecasting.pymake_fixed_viewpoint_forecasts(wasraise NotImplementedErrorstub)make_rolling_viewpoint_forecasts→make_forecasts; updatecreate_forecasting_jobsandhandle_forecasting_exceptionaccordinglysupported_horizons()call and theInvalidHorizonExceptionraise that blocked forecasting for horizons outside[1h, 6h, 24h, 48h]utils/time_utils.py— Removesupported_horizons()(no remaining callers)data/models/forecasting/exceptions.py— Remove orphanedInvalidHorizonExceptionclassdata/tests/test_forecasting_jobs.py— Removetest_failed_forecasting_invalid_horizon(tested the now-removed validation)The fallback-to-naive-model behaviour in
handle_forecasting_exceptionis preserved; it now correctly referencesmake_forecasts.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphql/usr/bin/gh gh pr view --json number --root y bash 42bdf9bf1e93f628d3e661a5ac322d60072/2a832965bc3a2b16d7bd54c7dabcd8d924da890d438336a3c31dee2db2265c29.pid 0be0ea4aa4b9132b/usr/bin/runc a4ad0a7a01ece153--root 8868270e2026a72b/var/run/docker/runtime-runc/moby --no�� --noprofile s1615070855 /usr/local/bin/rjson by/bfca6af4ab756grep 8a1acf2beb64f716-q(http block)If you need me to access, download, or install something from one of these locations, you can either: