Feat: Return inflexible device schedules from StorageScheduler#1994
Draft
Ahmad-Wahid wants to merge 9 commits intomainfrom
Draft
Feat: Return inflexible device schedules from StorageScheduler#1994Ahmad-Wahid wants to merge 9 commits intomainfrom
Ahmad-Wahid wants to merge 9 commits intomainfrom
Conversation
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Documentation build overview
Show files changed (1 files in total): 📝 1 modified | ➕ 0 added | ➖ 0 deleted
|
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Contributor
|
@Ahmad-Wahid what about this PR? |
Flix6x
reviewed
Mar 23, 2026
| if not self.config_deserialized: | ||
| self.deserialize_config() | ||
|
|
||
| # todo: look for the reason why flex_model has an object(dict) without a sensor, and fix the root cause if possible, instead of filtering it out here |
Contributor
There was a problem hiding this comment.
I know why this can happen. It happens when the db flex model of an asset is picked up when its parent asset is being scheduled. That means some devices are included in the optimization with only an asset ID known, and the power sensor ID to save the results is not guaranteed to be known.
Let's discuss what that means for this PR.
Comment on lines
+1467
to
+1476
| inflexible_device_schedules = [ | ||
| { | ||
| "name": "inflexible_device_schedule", | ||
| "sensor": sensor, | ||
| "data": inflexible_schedules[sensor], | ||
| "unit": sensor.unit, | ||
| } | ||
| for sensor in inflexible_schedules.keys() | ||
| if sensor is not None | ||
| ] |
Contributor
There was a problem hiding this comment.
This also means data/services/scheduling.py ends up saving the inflexible schedules to the sensors where their forecasts were being read from. Does that have added value?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sensor=None(TODO: fix root cause).inflexible_device_sensorsthrough_prepare()and extract their schedules from the EMS solution.return_multiple=True, includeinflexible_device_scheduleoutputs (with unit conversion + resampling/rounding aligned with storage schedules).How to test
Sign-off