Add multi‑commodity support to device scheduler#1946
Draft
Ahmad-Wahid wants to merge 47 commits intofeat/switching-between-gas-and-electricityfrom
Draft
Add multi‑commodity support to device scheduler#1946Ahmad-Wahid wants to merge 47 commits intofeat/switching-between-gas-and-electricityfrom
Ahmad-Wahid wants to merge 47 commits intofeat/switching-between-gas-and-electricityfrom
Conversation
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Documentation build overview
Show files changed (6 files in total): 📝 4 modified | ➕ 2 added | ➖ 0 deleted
|
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
…chemas Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
This reverts commit b22c6d7.
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Contributor
Author
|
@Flix6x could you please suggest some assertions for both test cases? |
Contributor
|
Please comment on why the test suite is failing. |
Contributor
Author
|
Please try to run these test cases: |
Flix6x
requested changes
Feb 19, 2026
Contributor
Flix6x
left a comment
Flix6x
left a comment
There was a problem hiding this comment.
I reviewed the two tests.
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Contributor
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
This reverts commit 2becd02.
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Contributor
|
@Ahmad-Wahid Maybe we should move the preference to charge sooner (and discharge later) to a per-device StockCommitment instead of a per-device FlowCommitment. The StockCommitment should use a tiny negative up-price for SoC > 0, and no down-price, so it prefers being full over being empty, all else being equal. Update: moved out to #2023 |
…eat/multi-commodity # Conflicts: # documentation/concepts/commitments.rst # flexmeasures/data/models/planning/__init__.py # flexmeasures/data/models/planning/storage.py
…lectricity' into feat/multi-commodity # Conflicts: # flexmeasures/data/models/planning/tests/test_commitments.py
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
…eat/multi-commodity
…ulti-commodity # Conflicts: # flexmeasures/data/models/planning/tests/test_commitments.py
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
…han later Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for multi‑commodity commitments (e.g. gas and electricity) in the device_scheduler, building on the grouped‑devices functionality. Flow commitments can now be tagged with a commodity, and EMS‑level flow constraints are applied per commodity by aggregating the relevant devices.
TODO
closes https://github.com/SeitaBV/simulations/issues/987