feat: redesign feedback annotation toolbar#11
Draft
olyaiy wants to merge 4 commits into
Draft
Conversation
Keep visual edit previews applied across annotation popup close/reopen, fold visual change summaries into the target pill, and make removing that pill detach the target without losing the comment text.
Tie the card and trigger together visually so the trigger physically sits at the card's anchor corner and acts as the close X. - Anchor the card directly to the trigger rect (no gap), pick the open direction based on viewport space, and reserve corner room in the card for the trigger - Animate card open/exit by scaling non-uniformly from the trigger rect to the full card with a matching border-radius morph and content fade - Crossfade the trigger icon between pencil and close glyphs while the card is open, dropping the redundant in-card close button - Flatten the trigger when the card is open (no border/background/shadow) and render hover/active/focus feedback on an inset ::before pill so the affordance stays inside the card's rounded corner instead of spilling out as a floating pill - Add a fresh-pin enter animation and inline-popup enter/transition animations - Respect prefers-reduced-motion across the morph, trigger, card, pins, and inline popup - Drop the rect-height check from visual suggestion text classification
Move the feedback widget to a draggable toolbar with numbered pin annotations, inline live style tweaks, and a post-submit progress banner for autobuild previews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commits
8a0e394Refines the inline annotation flow and opt-in behavior.02bd449Persists visual preview changes across annotation popover close/reopen.136eb89Polishes the old trigger/card transition before the toolbar redesign.3b2f9ecRedesigns the feedback flow around the draggable toolbar, pins, tweak controls, and submit banner.Test plan
bunx tsc --noEmitbun test tests/unitbun run buildNotes