fix: improve error messaging when saving custom field#7578
Merged
Conversation
Replace the generic "Failed to save custom field" toast with a phase-aware message that distinguishes a failure to create the MetadataField from a failure to bind it to a content type. When the field was created but the binding call failed (e.g. 403 for non-admin project administrators, see #7424), tell the user the field is orphaned and needs an organisation administrator to finish or remove it. Other errors now bubble up the backend detail string instead of being swallowed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
Bot
added
front-end
Contributor
Docker builds report
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances error handling in the CreateMetadataField component by introducing logic to extract specific error details from API responses and providing context-aware messages for different failure phases, such as field creation versus binding. A review comment identifies that the current error extraction logic is too restrictive and suggests a more robust implementation to handle various backend error formats, such as those from Django Rest Framework, to ensure users receive informative feedback.
Contributor
Visual RegressionNo baseline found — first run. Baselines will be generated after merge to main. |
kyle-ssg
changed the title
Address review feedback on #7578: getErrorDetail now extracts messages from DRF field-error objects, non_field_errors arrays, raw string errors, and network failures with message/error properties. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Drop the custom getErrorDetail/buildErrorMessage parsers in favour of the existing <ErrorMessage> component, which already handles DRF detail, non_field_errors, field-error objects and Error instances. Store the caught error in state and render it inline, with a separate warning banner when a successful create was followed by a binding failure (the orphaned-field case from #7424). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
When a custom field create succeeds but the binding call fails, show only the orphan-explanation message rather than stacking it above the generic permission error. The orphan message already covers the user's next step. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
talissoncosta
approved these changes
May 22, 2026
Contributor
talissoncosta
left a comment
talissoncosta
left a comment
There was a problem hiding this comment.
LGTM. Thanks for handling that @kyle-ssg !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
Changes
Contributes to #7424
This PR improves the error messaging for creating metadata fields.
How did you test this code?