Skip to content

fix: don't convert identity override value to string #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matevzmihalic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: don't convert identity override value to string #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions flagengine/engine_eval/mappers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ func mapRuleType(t segments.RuleType) Type {
type overridesKey struct {
featureName string
enabled bool
featureValue string
featureValue any
}

// overridesKeyList is a sortable slice of overridesKey.
Expand All @@ -185,7 +185,7 @@ func generateHash(overrides overridesKeyList) string {
// Create a string representation of the overrides
var hashInput string
for _, override := range overrides {
hashInput += fmt.Sprintf("%s:%t:%s;", override.featureName, override.enabled, override.featureValue)
hashInput += fmt.Sprintf("%s:%t:%v;", override.featureName, override.enabled, override.featureValue)
}

// Generate SHA256 hash
Expand All @@ -208,18 +208,13 @@ func mapIdentityOverridesToSegments(identityOverrides []*identities.IdentityMode
// Create overrides key from sorted features
var overrides overridesKeyList
for _, featureState := range identityOverride.IdentityFeatures {
featureValue := ""
if featureState.RawValue != nil {
featureValue = fmt.Sprint(featureState.RawValue)
}

// Store feature name to ID mapping for later lookup
featureNameToID[featureState.Feature.Name] = featureState.Feature.ID

overrides = append(overrides, overridesKey{
featureName: featureState.Feature.Name,
enabled: featureState.Enabled,
featureValue: featureValue,
featureValue: featureState.RawValue,
})
}

Expand Down
Loading