deps: move pyfakefs to dependencies (from dev dependencies)#79
Closed
matthewelwell wants to merge 3 commits into
Closed
deps: move pyfakefs to dependencies (from dev dependencies)#79matthewelwell wants to merge 3 commits into
matthewelwell wants to merge 3 commits into
Conversation
# Conflicts: # poetry.lock
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 94.17% 94.17%
=======================================
Files 74 74
Lines 2147 2147
=======================================
Hits 2022 2022
Misses 125 125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
khvn26
reviewed
May 27, 2025
khvn26
left a comment
Member
There was a problem hiding this comment.
pyfakefs is already listed as an optional dependency for the test-tools extra.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves pyfakefs from dev dependencies to the main dependencies section.
This is needed because flagsmith-common now includes it's own fixtures which are used in packages that depend on
flagsmith-common. Our options are to add pyfakefs as a dependency as we are here, or to add pyfakefs as a dev dependency in all of the repositories which depend upon it.I have elected for the former as it is cleaner (although not without it's downsides).