Skip to content

deps: move pyfakefs to dependencies (from dev dependencies)#79

Closed
matthewelwell wants to merge 3 commits into
mainfrom
deps/move-pyfakefs-to-core-deps
Closed

deps: move pyfakefs to dependencies (from dev dependencies)#79
matthewelwell wants to merge 3 commits into
mainfrom
deps/move-pyfakefs-to-core-deps

Conversation

@matthewelwell

Copy link
Copy Markdown
Contributor

This PR moves pyfakefs from dev dependencies to the main dependencies section.

This is needed because flagsmith-common now includes it's own fixtures which are used in packages that depend on flagsmith-common. Our options are to add pyfakefs as a dependency as we are here, or to add pyfakefs as a dev dependency in all of the repositories which depend upon it.

I have elected for the former as it is cleaner (although not without it's downsides).

@matthewelwell matthewelwell requested a review from a team as a code owner May 27, 2025 11:09
@matthewelwell matthewelwell requested review from emyller and removed request for a team May 27, 2025 11:09
@matthewelwell matthewelwell requested review from khvn26 and removed request for emyller May 27, 2025 11:10
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.17%. Comparing base (fc2dce3) to head (6552e9c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files          74       74           
  Lines        2147     2147           
=======================================
  Hits         2022     2022           
  Misses        125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@khvn26 khvn26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyfakefs is already listed as an optional dependency for the test-tools extra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants