-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: add support for IBM Bob coding assistant #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rdruss
wants to merge
8
commits into
Fission-AI:main
Choose a base branch
from
rdruss:feat/bob-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
87d82b1
test: add comprehensive tests for Bob Shell adapter
rdruss 2779a53
feat: add Bob Shell adapter support
rdruss b92ab60
docs: add Bob Shell to supported tools documentation
rdruss ddff394
docs: add Bob Shell support proposal and design documentation
rdruss 46ecebc
chore: update dependencies and gitignore
rdruss a6d4583
chore: update gitignore to exclude .bob directory
rdruss e99889d
openspec change not needed for project, should be kept local
rdruss 0da36ff
Update reference from Bob Shell to IBM Bob Shell
rdruss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -156,3 +156,6 @@ opencode.json | |
|
|
||
| # Codex | ||
| .codex/ | ||
|
|
||
| # Bob | ||
| .bob/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /** | ||
| * Bob Shell Command Adapter | ||
| * | ||
| * Formats commands for Bob Shell following its markdown specification. | ||
| * Commands are stored in .bob/commands/ directory. | ||
| */ | ||
|
|
||
| import path from 'path'; | ||
| import type { CommandContent, ToolCommandAdapter } from '../types.js'; | ||
|
|
||
| /** | ||
| * Escapes a string value for safe YAML output. | ||
| * Quotes the string if it contains special YAML characters. | ||
| */ | ||
| function escapeYamlValue(value: string): string { | ||
| // Check if value needs quoting (contains special YAML characters or starts/ends with whitespace) | ||
| const needsQuoting = /[:\n\r#{}[\],&*!|>'"%@`]|^\s|\s$/.test(value); | ||
| if (needsQuoting) { | ||
| // Use double quotes and escape internal double quotes and backslashes | ||
| const escaped = value.replace(/\\/g, '\\\\').replace(/"/g, '\\"').replace(/\n/g, '\\n'); | ||
| return `"${escaped}"`; | ||
| } | ||
| return value; | ||
| } | ||
|
|
||
| /** | ||
| * Bob Shell adapter for command generation. | ||
| * File path: .bob/commands/opsx-<id>.md | ||
| * Frontmatter: description (optional) | ||
| */ | ||
| export const bobAdapter: ToolCommandAdapter = { | ||
| toolId: 'bob', | ||
|
|
||
| getFilePath(commandId: string): string { | ||
| return path.join('.bob', 'commands', `opsx-${commandId}.md`); | ||
| }, | ||
|
|
||
| formatFile(content: CommandContent): string { | ||
| // Bob Shell supports optional YAML frontmatter with description field | ||
| return `--- | ||
| description: ${escapeYamlValue(content.description)} | ||
| --- | ||
|
|
||
| ${content.body} | ||
| `; | ||
| }, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Escape
\ras well when serializing YAML description.escapeYamlValueflags carriage returns at Line 17, but Line 20 doesn’t escape them. That can produce malformed or parser-dependent frontmatter on CRLF input.🔧 Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents