Skip to content

Fixed NetworkCollider bug to allow for comparisons between current tick and last tick stored sets #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
strakerak wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed NetworkCollider bug to allow for comparisons between current tick and last tick stored sets #1041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8afebb
Update NetworkCollider.cs
strakerak May 15, 2026
c960164
Update NetworkCollider2D.cs
strakerak May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Assets/FishNet/Runtime/Generated/Component/Prediction/NetworkCollider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ protected override void CheckColliders(uint localTick)
if (lastTick is not unsetLastTick && _enteredColliders.TryGetValueIL2CPP(localTick, out HashSet<Collider> lEnteredColliders))
{
CollectionCaches<Collider>.Store(lEnteredColliders);
_enteredColliders.Remove(localTick);
_enteredColliders.Remove(lastTick);
}
}
}
Expand Down Expand Up @@ -318,4 +318,4 @@ private void StoreEnteredColliders(bool keepDictionary)
CollectionCaches<uint, HashSet<Collider>>.Store(_enteredColliders);
}
}
}
}
4 changes: 2 additions & 2 deletions Assets/FishNet/Runtime/Generated/Component/Prediction/NetworkCollider2D.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ protected override void CheckColliders(uint localTick)
if (lastTick is not unsetLastTick && _enteredColliders.TryGetValueIL2CPP(localTick, out HashSet<Collider2D> lEnteredColliders))
{
CollectionCaches<Collider2D>.Store(lEnteredColliders);
_enteredColliders.Remove(localTick);
_enteredColliders.Remove(lastTick);
}
}
}
Expand Down Expand Up @@ -306,4 +306,4 @@ private void StoreEnteredColliders(bool keepDictionary)
CollectionCaches<uint, HashSet<Collider2D>>.Store(_enteredColliders);
}
}
}
}