Add font specification Yu-Gothic for Mac and Windows, Noto Sans CJK for Linux.#84
Open
logue wants to merge 3 commits intoFirestormViewer:masterfrom
Open
Add font specification Yu-Gothic for Mac and Windows, Noto Sans CJK for Linux.#84logue wants to merge 3 commits intoFirestormViewer:masterfrom
logue wants to merge 3 commits intoFirestormViewer:masterfrom
Conversation
Contributor
|
Thanks for the PR, I noted on the JIRA that this is still buried in the upstream LL develop branch so we may hold this until it flows down from them and then apply this if it it still required. I have asked @PanteraPolnocy who looks after the translators to see if there are any side-effects of this in the meantime. |
Member
|
To avoid merge conflicts, I'd rather wait for the upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.firestormviewer.org/browse/FIRE-35204