Skip to content

FIX - Profile Pick save buttons wrongfully enabled while preview mode is active#197

Merged
Ansariel merged 2 commits intoFirestormViewer:masterfrom
trish-sl:fix-profilepickpreviewmode
Mar 9, 2026
Merged

FIX - Profile Pick save buttons wrongfully enabled while preview mode is active#197
Ansariel merged 2 commits intoFirestormViewer:masterfrom
trish-sl:fix-profilepickpreviewmode

Conversation

@trish-sl
Copy link
Copy Markdown
Contributor

I could not find a JIRA referencing this problem.

Bug

When using the preview mode within profile picks, the save button is correctly disabled.
However, several actions can cause this to be bypassed. When saving a pick, mPreview mode should be OFF or turned off to prevent the pick from saving while in preview mode. If a pick is saved while in preview, it saves incorrectly (it removes links).

Reproduction

  1. A first case of this bug is when you edit a pick with a link inside, go to preview mode, then close the floater. The pop up that asks you to save or discard the changes will cause the pick to save while in preview mode if you click "Save". Instead, it should turn off preview mode, then save before closing the floater.
  2. A second case of this bug is when you edit a pick, go to preview mode, then "Set location". The save buttons are wrongfully re-enabled.

Fix

For case 1), I've made it so the save & quit will toggle off preview before saving.
For case 2), I gated the function to enable save buttons to cover all cases of it being enabled while preview is on. This is the least invasive change I could find that will remain compatible with future changes from LL

@trish-sl
Copy link
Copy Markdown
Contributor Author

Turns out, the same bug was happening in the profile description and first life tab, so I incorporated the same fix there. (Turn off preview mode after choosing save & quit)

@Ansariel
Copy link
Copy Markdown
Collaborator

Ansariel commented Mar 9, 2026

Thanks for the fixes!

@Ansariel Ansariel merged commit 115f1fa into FirestormViewer:master Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants