FIX - Profile Pick save buttons wrongfully enabled while preview mode is active#197
Merged
Ansariel merged 2 commits intoFirestormViewer:masterfrom Mar 9, 2026
Merged
Conversation
Contributor
Author
|
Turns out, the same bug was happening in the profile description and first life tab, so I incorporated the same fix there. (Turn off preview mode after choosing save & quit) |
Collaborator
|
Thanks for the fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could not find a JIRA referencing this problem.
Bug
When using the preview mode within profile picks, the save button is correctly disabled.
However, several actions can cause this to be bypassed. When saving a pick, mPreview mode should be OFF or turned off to prevent the pick from saving while in preview mode. If a pick is saved while in preview, it saves incorrectly (it removes links).
Reproduction
Fix
For case 1), I've made it so the save & quit will toggle off preview before saving.
For case 2), I gated the function to enable save buttons to cover all cases of it being enabled while preview is on. This is the least invasive change I could find that will remain compatible with future changes from LL