[FIRE-35656] Add privacy option to block payment notification from mu…#145
Open
casperwardensl wants to merge 1 commit intoFirestormViewer:masterfrom
Open
[FIRE-35656] Add privacy option to block payment notification from mu…#145casperwardensl wants to merge 1 commit intoFirestormViewer:masterfrom
casperwardensl wants to merge 1 commit intoFirestormViewer:masterfrom
Conversation
Collaborator
|
Wouldn't it make sense to exit early? It seems the payment still will show up in the money tracker - should that still be the case? |
Contributor
|
@casperwardensl poke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a privacy option t make payment notifications not show at all if the payment is from muted avatars.
The current implementation removes the "reason", but users can still be harassed by the dialogs - it can be distressing to see a name pop up continuously in certain situations.