add auto-function-call requests#59
Conversation
Summary of ChangesHello @davidmotson, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the existing mock response data by introducing new JSON files that simulate successful auto-function call responses from Vertex AI. These additions are crucial for testing and development workflows that rely on the model's ability to generate and suggest function executions, covering both single and parallel function call scenarios. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Coverage Diff |
There was a problem hiding this comment.
Code Review
This pull request adds two new mock JSON responses for Vertex AI auto-function-call scenarios. The overall structure looks good, but I've noticed an inconsistency in how function arguments are structured compared to existing mock files. The new files wrap arguments within a param object, which seems unnecessary and could lead to incorrect test assumptions. I've left suggestions to flatten the argument structure for consistency.
| "param": { | ||
| "state": "MA", | ||
| "city": "Boston", | ||
| "date": "2024-10-17" | ||
| } |
There was a problem hiding this comment.
The args object appears to have an unnecessary level of nesting with the param key. Other mock responses in this repository (e.g., unary-success-function-call-with-arguments.json) define arguments directly within the args object. This inconsistency could cause issues in tests that rely on this mock data. I suggest flattening the structure for consistency and to better reflect the likely API contract.
"state": "MA",
"city": "Boston",
"date": "2024-10-17"| "param": { | ||
| "state": "MA", | ||
| "city": "Boston", | ||
| "date": "2024-10-17" | ||
| } |
There was a problem hiding this comment.
| "param": { | ||
| "state": "MA", | ||
| "city": "Boston", | ||
| "date": "2024-10-17" | ||
| } |
There was a problem hiding this comment.
The args for completelyDifferentFunction also have the param nesting. It's unlikely that two different functions would share this exact argument structure. The arguments should probably be flattened here as well. Additionally, it's worth verifying if these are the correct arguments for completelyDifferentFunction, as they are identical to those for fetchWeather.
"state": "MA",
"city": "Boston",
"date": "2024-10-17"
No description provided.