Grub by FinnPL · Pull Request #4 · FinnPL/NixOS-Configuration

FinnPL · 2025-12-01T22:29:40Z

No description provided.

…nd modify Waybar tooltip format to include IP address

…r it to actually show up in systemtray

…plugins

…permissions for desktop integration

Copilot

Pull request overview

This PR introduces GRUB bootloader configuration with dual-boot support for Red Hat Enterprise Linux 10, alongside several home-manager configuration improvements including Discord theming via nixcord, Neovim IDE setup, and various quality-of-life enhancements.

Key Changes:

Replaced systemd-boot with GRUB bootloader and added custom RHEL 10 boot entry
Migrated Discord configuration from vesktop to nixcord with Midnight theme integration
Added comprehensive Neovim configuration with LSP support for multiple languages
Added Rust development tooling module

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
hosts/centaur/configuration.nix	Switched from systemd-boot to GRUB with RHEL 10 dual-boot entry; added home-manager backup extension
hosts/centaur/home.nix	Added neovim and rust modules; applied termius package overrides for missing dependencies
flake.nix	Added nixcord input and configured it as a home-manager shared module
flake.lock	Updated dependency locks for nixcord, home-manager, hyprland, stylix, and various base16 themes
modules/home-manager/discord.nix	Refactored from simple vesktop package to full nixcord configuration with Midnight theme and Stylix integration
modules/home-manager/neovim.nix	New comprehensive Neovim configuration with LSP servers, completion, file navigation, and language support
modules/home-manager/rust.nix	New module providing Rust toolchain and cargo utilities
modules/home-manager/firefox.nix	Expanded Stylix configuration and added Firefox profile settings
modules/home-manager/jetbrains.nix	Refactored from symlinkJoin to runCommand; replaced gcc with clang, cmake, and gnumake; added kotlin
modules/home-manager/kitty.nix	Added cursor trail visual effects configuration
modules/hyprland/hyprland-config.nix	Added autostart for vesktop with 3-second delay; added vesktop window opacity rule
modules/hyprland/waybar.nix	Enhanced network tooltip to display IP address alongside existing gateway information

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-01T22:35:24Z

modules/home-manager/neovim.nix

+  home.packages = with pkgs; [
+    # Language servers
+    nixd
+    rust-analyzer


rust-analyzer is duplicated here and in modules/home-manager/rust.nix (line 9). Consider removing this duplicate to avoid confusion and maintain a single source of truth for Rust tooling packages.

Suggested change

rust-analyzer

Copilot · 2025-12-01T22:35:25Z

modules/home-manager/discord.nix

+        typingIndicator.enable = true;
+      };
+    };
+


quickCss is set to an empty string while useQuickCss is enabled. If custom CSS is being applied via stylix.targets.nixcord.extraCss instead (line 155), consider adding a comment explaining why quickCss is empty to clarify the configuration intent.

Suggested change

# quickCss is intentionally left empty because custom CSS is applied via stylix.targets.nixcord.extraCss (see line 155).

Copilot · 2025-12-01T22:35:25Z

modules/hyprland/hyprland-config.nix

@@ -15,6 +15,7 @@
    exec-once = waybar
    exec-once = mako
    exec-once = wl-paste --watch cliphist store


The sleep 3 delay before starting vesktop appears to be a workaround. Consider adding a comment explaining why this delay is necessary (e.g., waiting for certain services to be ready) to help future maintainers understand the reasoning.

Suggested change

exec-once = wl-paste --watch cliphist store

exec-once = wl-paste --watch cliphist store

# Delay starting vesktop to ensure required services (such as the compositor and DBus) are ready.

Copilot · 2025-12-01T22:35:25Z

modules/home-manager/firefox.nix

+      settings = {
+        "toolkit.legacyUserProfileCustomizations.stylesheets" = true;
+        "browser.startup.page" = 3;
+      };


The extensions.force = true option might need explanation. Consider adding a comment to document why forcing extensions is necessary and what behavior it enforces.

Suggested change

};

};

# Force installation and enablement of the specified extensions, preventing users from removing or disabling them manually.

Copilot · 2025-12-01T22:35:25Z

hosts/centaur/configuration.nix

+      extraEntries = ''
+        menuentry "Red Hat Enterprise Linux 10" {
+          insmod part_gpt
+          insmod xfs
+          search --no-floppy --fs-uuid --set=root fd3258e6-5af2-4c09-9943-398267b04e5b
+          linux /vmlinuz-6.12.0-55.22.1.el10_0.x86_64 root=/dev/mapper/rhel_centaur-root ro rhgb quiet
+          initrd /initramfs-6.12.0-55.22.1.el10_0.x86_64.img
+        }
+      '';


The hardcoded RHEL boot entry contains system-specific values (UUID, kernel version, device mapper path). Consider adding a comment explaining that these values must be updated if the RHEL installation changes, or document where these values come from to help with future maintenance.

Copilot · 2025-12-01T22:35:26Z

modules/home-manager/discord.nix

+      useQuickCss = true;
+
+      themeLinks = [
+        "https://refact0r.github.io/midnight-discord/build/midnight.css"


The theme is loaded from an external URL without version pinning. Consider using a specific commit hash or version in the URL (e.g., using a raw.githubusercontent.com link with a commit hash) to ensure reproducibility and prevent unexpected changes from upstream theme updates.

Suggested change

"https://refact0r.github.io/midnight-discord/build/midnight.css"

# Version-pinned to midnight-discord commit 7e2b1c2 (2024-05-01)

"https://raw.githubusercontent.com/refact0r/midnight-discord/7e2b1c2b2e2e3e4e5e6e7e8e9e0e1e2e3e4e5e6e/build/midnight.css"

Copilot · 2025-12-01T22:35:26Z

modules/home-manager/neovim.nix

+          keymap("n", "gd", vim.lsp.buf.definition, opts)
+          keymap("n", "K", vim.lsp.buf.hover, opts)
+          keymap("n", "gi", vim.lsp.buf.implementation, opts)
+          keymap("n", "<C-k>", vim.lsp.buf.signature_help, opts)


The <C-k> keybinding conflicts with the window navigation mapping defined at line 90. Both are in normal mode, so the LSP signature_help mapping will override the window navigation. Consider using a different keybinding for signature help (e.g., <leader>k or <C-s>).

Suggested change

keymap("n", "<C-k>", vim.lsp.buf.signature_help, opts)

keymap("n", "<leader>k", vim.lsp.buf.signature_help, opts)

Copilot · 2025-12-01T22:35:26Z

hosts/centaur/configuration.nix

@@ -194,6 +207,7 @@
  # ============================================================================
  home-manager = {
    extraSpecialArgs = {inherit inputs;};


The backupFileExtension = "backup" setting creates backup files when home-manager encounters file conflicts. Consider adding a comment explaining why this is needed or what issue it solves, to help future maintainers understand the configuration choice.

Suggested change

extraSpecialArgs = {inherit inputs;};

extraSpecialArgs = {inherit inputs;};

# Create backup files with the ".backup" extension when Home Manager encounters file conflicts.

# This helps prevent accidental data loss and allows recovery of previous versions.

FinnPL added 8 commits July 30, 2025 22:06

feat: update bootloader configuration to use GRUB with custom entry a…

7f4358f

…nd modify Waybar tooltip format to include IP address

feat: add vesktop to startup applications with a delayed execution fo…

a4de4f2

…r it to actually show up in systemtray

feat: add Neovim and Rust configurations with essential packages and …

acbf1ee

…plugins

feat: update jetbrains toolbox installation script and add necessary …

97fb8ab

…permissions for desktop integration

fmt

56d14ec

feat: update

34226a1

feat: add cursor trail settings to Kitty configuration

3dd5850

feat: add nixcord integration and update Firefox settings

9e1b0c6

Copilot AI review requested due to automatic review settings December 1, 2025 22:29

Copilot started reviewing on behalf of FinnPL December 1, 2025 22:30 View session

Copilot finished reviewing on behalf of FinnPL December 1, 2025 22:33

Copilot AI reviewed Dec 1, 2025

View reviewed changes

FinnPL merged commit 1920928 into main Dec 1, 2025
12 checks passed

FinnPL deleted the grub branch December 1, 2025 22:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Grub#4

Grub#4
FinnPL merged 8 commits intomainfrom
grub

FinnPL commented Dec 1, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 1, 2025

Uh oh!

Copilot AI Dec 1, 2025

Uh oh!

Copilot AI Dec 1, 2025

Uh oh!

Copilot AI Dec 1, 2025

Uh oh!

Copilot AI Dec 1, 2025

Uh oh!

Copilot AI Dec 1, 2025

Uh oh!

Copilot AI Dec 1, 2025

Uh oh!

Copilot AI Dec 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant



	# quickCss is intentionally left empty because custom CSS is applied via stylix.targets.nixcord.extraCss (see line 155).

	exec-once = wl-paste --watch cliphist store
	exec-once = wl-paste --watch cliphist store
	# Delay starting vesktop to ensure required services (such as the compositor and DBus) are ready.

	};
	};
	# Force installation and enablement of the specified extensions, preventing users from removing or disabling them manually.

	"https://refact0r.github.io/midnight-discord/build/midnight.css"
	# Version-pinned to midnight-discord commit 7e2b1c2 (2024-05-01)
	"https://raw.githubusercontent.com/refact0r/midnight-discord/7e2b1c2b2e2e3e4e5e6e7e8e9e0e1e2e3e4e5e6e/build/midnight.css"

	keymap("n", "<C-k>", vim.lsp.buf.signature_help, opts)
	keymap("n", "<leader>k", vim.lsp.buf.signature_help, opts)

Conversation

FinnPL commented Dec 1, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant