Skip to content

Skip HTML5 required attribute for bool #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
austins wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Skip HTML5 required attribute for bool #13

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18680f2
fix: skip HTML5 required attribute for bool properties
austins May 27, 2026
fd9b8ca
fix: skip HTML5 required attribute for bool
austins May 27, 2026
8eb5b0e
Merge remote-tracking branch 'origin/bool-checkbox-norequired' into b…
austins May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Finbuckle.Html5Validation/Internal/RequiredAttributeAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@ public override void AddValidation(ClientModelValidationContext context)
throw new ArgumentNullException(nameof(context));
}

// ASP.NET Core marks bool with RequiredAttribute. Don't add the HTML5 required attribute for bool
// as it would cause unchecked checkboxes to block form submission in the browser.
// This matches the behavior of the built-in client-side validation.
if (context.ModelMetadata.ModelType == typeof(bool))
{
return;
}

MergeAttribute(context.Attributes, "required", "");
MergeErrorMessageTitle(context);
}
Expand Down