Skip to content

fix: foc-wg PR notifier workflow#44

Merged
rjan90 merged 1 commit into
masterfrom
codex/fix-foc-wg-pr-notifier-workflow
May 22, 2026
Merged

fix: foc-wg PR notifier workflow#44
rjan90 merged 1 commit into
masterfrom
codex/fix-foc-wg-pr-notifier-workflow

Conversation

@rjan90
Copy link
Copy Markdown
Contributor

@rjan90 rjan90 commented May 21, 2026

Summary

Fix the standalone FOC-WG PR notifier so it can import the sibling github-projects-client package from a plain GitHub Actions checkout.

Root cause

The notifier added foc-pr-report to sys.path, but foc-pr-report now imports github_projects_client.api. The scheduled workflow only installs root requirements, so the notifier failed before reaching credential checks with ModuleNotFoundError.

Validation

  • python3 foc_wg_pr_notifier.py --dry-run now reaches the expected missing-token guard instead of an import traceback
  • python3 -m py_compile foc_wg_pr_notifier.py foc-pr-report/foc_pr_report/pr_enrichment.py github-projects-client/github_projects_client/api.py

@FilOzzy FilOzzy added this to FOC May 21, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC May 21, 2026
@rjan90 rjan90 self-assigned this May 22, 2026
@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting review in FOC May 22, 2026
@rjan90 rjan90 added this to the M4.2: mainnet GA milestone May 22, 2026
@rjan90 rjan90 marked this pull request as ready for review May 22, 2026 07:36
@rjan90 rjan90 requested a review from TippyFlitsUK May 22, 2026 07:53
@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FOC May 22, 2026
@rjan90 rjan90 merged commit 6c0c9dd into master May 22, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

3 participants