feat(costs)!: per-operation pricing price list#823
Open
SgtPooki wants to merge 15 commits into
Open
Conversation
c6b9a5f to
847c4de
Compare
Collaborator
|
@SgtPooki you should be able to change the generated.ts to point to a commit hash and get new ABI pulled in. I think this is fine, we're nearing the last of the changes pre-GA and it wouldn't be terrible to merge in a specific commit that's not on a tag, we can always follow-up later (and we'll get the auto PR now that there's a workflow in place). |
rvagg
reviewed
Jun 4, 2026
rvagg
reviewed
Jun 4, 2026
rvagg
reviewed
Jun 4, 2026
rvagg
reviewed
Jun 4, 2026
rvagg
reviewed
Jun 4, 2026
rvagg
reviewed
Jun 4, 2026
rvagg
reviewed
Jun 4, 2026
rvagg
reviewed
Jun 4, 2026
rvagg
reviewed
Jun 4, 2026
rvagg
reviewed
Jun 4, 2026
847c4de to
79118bb
Compare
Copilot stopped reviewing on behalf of
SgtPooki due to an error
June 4, 2026 19:04
Copilot stopped reviewing on behalf of
SgtPooki due to an error
June 4, 2026 19:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Reshapes the Costs API to the GA per-operation pricing model.
getPriceList()reads the fulltoken/rates/fees/lockupscatalogue fromFilecoinWarmStorageServiceStateView.getPriceList()(filecoin-services#501); the effective-rate, lockup, deposit, and upload-cost paths,StorageManager, and the ReactusePriceListhook all read from it. Operator-approvalmaxLockupPeriodnow readsgetPriceList().lockups.defaultLockupPeriod(filecoin-services#503).How to verify
pnpm -F @filoz/synapse-core build && pnpm -F @filoz/synapse-sdk build pnpm -F @filoz/synapse-core test:node pnpm -F @filoz/synapse-sdk test:nodeNotes / risks
getPriceList()reverts on the current live contracts and there is no fallback (mocked tests pass).getPriceListfragment (src/abis/price-list.ts) instead of bumping the generated ref; in-code TODOs flag it for removal onceFILECOIN_SERVICES_GIT_REFincludesgetPriceList.BREAKING CHANGE: removes
getServicePrice()(core + SDK) anduseServicePrice()in favor ofgetPriceList()/usePriceList(); drops theratealias on upload costs (userates), theLOCKUP_PERIODexport, and theaddPiecesOperationCountcost option.