docs: address #469 subgraph PR feedback#542
Merged
Merged
Conversation
dennis-tra
changed the title
dennis-tra
changed the title
Contributor
Author
|
cc @BigLep |
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses review feedback from PR #469 by documenting the rationale for a dealbot-owned subgraph, adding a subgraph release checklist, and adding a drift test that asserts apps/subgraph/networks.json stays in sync with contract addresses from @filoz/synapse-core.
Changes:
- Add Motivation section and Release/Deployment pointer in
apps/subgraph/README.md; move deploy steps into a dedicated checklist. - New
docs/release-subgraph.mdchecklist and cross-links fromdocs/release-process.md. - New
apps/subgraph/scripts/check-networks.test.mjswired intopnpm testto fail fast on address drift.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/subgraph/README.md | Adds Motivation, replaces inline Deploy section with link to release checklist; inadvertently drops ## from the "What it indexes" heading. |
| apps/subgraph/package.json | Extends test to also run the new check-networks.test.mjs via node --test. |
| apps/subgraph/scripts/check-networks.test.mjs | New node:test assertions that networks.json matches synapse-core generated addresses for chain 314 and 314159. |
| docs/release-process.md | Clarifies scope (backend/web) and adds links to the new subgraph release doc. |
| docs/release-subgraph.md | New end-to-end subgraph release/deploy checklist for Goldsky. |
github-project-automation
Bot
moved this from 🔎 Awaiting review
to ✔️ Approved by reviewer
in FOC
BigLep
approved these changes
May 25, 2026
Contributor
BigLep
left a comment
BigLep
left a comment
There was a problem hiding this comment.
A few small comments, but looks good to me. Thanks for incorporating.
dennis-tra
force-pushed
the
subgraph-pr-feedback
branch
from
cd0c510 to
d657aad
Compare
Contributor
Author
|
@BigLep addressed your comments and also rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses comments from here: #469 (review)
Changelog: