-
Notifications
You must be signed in to change notification settings - Fork 9
feat: anon piece selection and retrieval #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dennis-tra
wants to merge
57
commits into
FilOzone:main
Choose a base branch
from
probe-lab:anon-retrieval
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
c9bdfa4
feat: anon piece selection and retrieval
dennis-tra 96c82c6
refactor(anon): only use clickhouse
dennis-tra 81a38b1
feat(retrieval-anon): track ipni metrics
dennis-tra 072a096
test(retrieval-anon): new ipni fields
dennis-tra 1fcee60
refactor(retrieval-anon): function signatures
dennis-tra 4527d29
refactor(retrieval-anon): cleanup
dennis-tra a797c15
chore: format code
dennis-tra 54cc487
fix: biome checks
dennis-tra fcfe569
fix(ipni): return actual verified/unverfied counts
dennis-tra fb45bd0
refactor: store anon retrieval data primarily in postgres
dennis-tra 92c40a8
Revert "refactor: store anon retrieval data primarily in postgres"
dennis-tra d4f7d80
refactor(retrieval-anon): introduce IpniCheckStatus enum and drop red…
dennis-tra ab3748a
remove(retrieval-anon): dedup window logic
dennis-tra beffac7
revert(ipni): sequential block CID verification
dennis-tra f26744b
docs(retrieval-anon): flow description and metrics definitions
dennis-tra 5cee3ee
docs: add missing anonymous retrieval env vars
dennis-tra 95a2dff
docs: fix obsolete reference to the pdp-explorer-owned subgraph
dennis-tra cff3171
improve: clarity around piece fetch status and commp validation
dennis-tra 3c2a698
refactor: let two subgraph endpoints coexist
dennis-tra d82222f
refactor: reduce pr diff noise
dennis-tra 527283f
remove: residual references to a pdp subgraph in the subgraph module
dennis-tra 8dfb3ca
Apply suggestion from @BigLep
dennis-tra b8a2621
chore: align pnpm-lock.yaml with main
dennis-tra 70af7c0
fix: wrong reference to an old maximum anon retrieval piece size
dennis-tra b003d78
docs: improve anon retrieval documentation
dennis-tra 21b4f2d
docs: fix accidental changes to untouched event descriptions
dennis-tra a4f0b38
rename: metric anonRetrievalStatus to anonPieceRetrievalStatus
dennis-tra 1a32373
fix: interpret abort signal as timed out for metric
dennis-tra fc8f378
docs: incorporate pr feedback
dennis-tra 12b5eb6
remove: unnecessary whitespace
dennis-tra 79b6bbc
fix(anon-retrieval): defer job during maintenance window
dennis-tra 9ae0457
fix(retrieval-anon): skip job if SP is blocked
dennis-tra d82bfaf
fix(retrieval-anon): gate job creation on subgraphEndpoint presence
dennis-tra 42f7568
refactor: use IpniCheckStatus enum values for check metrics
dennis-tra 19e3af3
fix(retrieval-anon): skip downstream validation for invalid commp
dennis-tra 2ef91a1
refactor(retrieval-anon): avoid nested ternaries
dennis-tra 30ca842
refactor(retrieval-anon): wire abort signal to piece selection
dennis-tra 33a3d99
refactor(retrieval-anon): wire abort signal to car validation
dennis-tra dadd4f8
fix(retrieval-anon): empty-string value fails Joi number coercion
dennis-tra 48ecadb
fix(retrieval-anon): treat commP mismatch as a fetch failure
dennis-tra 2850db8
docs: imporve anon retrieval event model / timeline
dennis-tra c325038
change(retrieval-anon): maximum size bucket to 100MiB
dennis-tra d098e37
fix(retrieval-anon): wrap-around sampleKey subgraph query
dennis-tra 70686e1
fix(retrieval-anon): handle aborted signal in car response
dennis-tra 007cfd7
fix(retrieval-anon): correctly interpret operator-driven cancellation
dennis-tra 9611e6c
docs(anon-retrievals): incorporate pr feedback
dennis-tra aa19374
refactor(anon-retrieval): decouple CAR parse / IPNI verify / Block Fetch
dennis-tra 24ef113
docs: claude review
dennis-tra afbf4ea
Merge branch 'main' into anon-retrieval
dennis-tra 9099370
docs: claude consolidation
dennis-tra 8d4c1f8
refactor: put newest anon retrieval table last
dennis-tra 2066a31
fix(retrieval-anon): mark job as failed if no piece was found
dennis-tra 24c9f55
fix: job service dep indices
dennis-tra 74a6c6d
Merge branch 'main' into anon-retrieval
dennis-tra 4714bf8
Update docs/checks/anon-retrievals.md
dennis-tra b3d7731
refactor(retrieval-anon): align check statuses to success/failure.* c…
dennis-tra 4666e0c
docs: clarify currently unused probe location field
dennis-tra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,3 +21,5 @@ coverage/ | |
| # per-package lockfiles are stray | ||
| apps/*/pnpm-lock.yaml | ||
| !pnpm-lock.yaml | ||
|
|
||
| .tool-versions | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is data that can be easily derived. Also is it
(ttlb-ttfb)/bytesor simplyttlb/bytes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's
http response size/total time of the HTTP requestThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it could easily be derived, I agree