Skip to content

fix: wait for clickhouse and postgres#443

Merged
SgtPooki merged 3 commits into
mainfrom
fix/local-overlay
May 4, 2026
Merged

fix: wait for clickhouse and postgres#443
SgtPooki merged 3 commits into
mainfrom
fix/local-overlay

Conversation

@SgtPooki
Copy link
Copy Markdown
Collaborator

@SgtPooki SgtPooki commented Apr 10, 2026

fix on top of #438 to ensure local cluster waits on postgres and clickhouse pods

Copilot AI review requested due to automatic review settings April 10, 2026 14:36
@FilOzzy FilOzzy added this to FOC Apr 10, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Apr 10, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the local Kustomize overlay to delay starting the backend and worker pods until their datastore dependencies are reachable, aiming to reduce crash loops during local boot.

Changes:

  • Adds a new backend patch to inject an initContainer that waits for Postgres and ClickHouse.
  • Adds a similar initContainer to the dealbot-worker Deployment.
  • Wires the new backend patch into the local overlay’s kustomization.yaml.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
kustomize/overlays/local/kustomization.yaml Adds the new backend startup-dependencies patch to the local overlay.
kustomize/overlays/local/dealbot-worker-deployment.yaml Adds an initContainer to wait for Postgres and ClickHouse before starting the worker.
kustomize/overlays/local/backend-startup-dependencies.yaml New strategic-merge patch to add an initContainer to the backend Deployment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread kustomize/overlays/local/backend-startup-dependencies.yaml Outdated
Comment thread kustomize/overlays/local/dealbot-worker-deployment.yaml Outdated
@BigLep BigLep moved this from 📌 Triage to 🔎 Awaiting review in FOC Apr 12, 2026
@BigLep BigLep requested a review from iand April 12, 2026 16:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SgtPooki
Copy link
Copy Markdown
Collaborator Author

Addressed Copilot comments: merged main into this branch to pick up the ClickHouse Deployment/Service/PVC/ConfigMap manifests. The ./clickhouse overlay is now included in kustomize/overlays/local/kustomization.yaml, so dealbot-clickhouse:8123 resolves correctly and the initContainer will find the service.

@SgtPooki SgtPooki requested a review from silent-cipher April 27, 2026 21:38
- grep -qxF treats "Ok." as fixed string so regex `.` no longer matches any char
- wget -T 5 prevents indefinite hang on slow or stuck endpoint
@SgtPooki SgtPooki requested a review from juliangruber May 4, 2026 15:19
@SgtPooki
Copy link
Copy Markdown
Collaborator Author

SgtPooki commented May 4, 2026

@silent-cipher @juliangruber this is a fairly lightweight PR, can I get a review?

Copy link
Copy Markdown
Collaborator

@silent-cipher silent-cipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I’m not deeply familiar with the kustomize/local yaml setup, but nothing stood out as concerning.

@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FOC May 4, 2026
@SgtPooki SgtPooki merged commit f48a50d into main May 4, 2026
7 checks passed
@SgtPooki SgtPooki deleted the fix/local-overlay branch May 4, 2026 20:36
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC May 4, 2026
Copy link
Copy Markdown
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

7 participants