fix: wait for clickhouse and postgres#443
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the local Kustomize overlay to delay starting the backend and worker pods until their datastore dependencies are reachable, aiming to reduce crash loops during local boot.
Changes:
- Adds a new backend patch to inject an initContainer that waits for Postgres and ClickHouse.
- Adds a similar initContainer to the dealbot-worker Deployment.
- Wires the new backend patch into the local overlay’s
kustomization.yaml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| kustomize/overlays/local/kustomization.yaml | Adds the new backend startup-dependencies patch to the local overlay. |
| kustomize/overlays/local/dealbot-worker-deployment.yaml | Adds an initContainer to wait for Postgres and ClickHouse before starting the worker. |
| kustomize/overlays/local/backend-startup-dependencies.yaml | New strategic-merge patch to add an initContainer to the backend Deployment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Addressed Copilot comments: merged main into this branch to pick up the ClickHouse Deployment/Service/PVC/ConfigMap manifests. The |
- grep -qxF treats "Ok." as fixed string so regex `.` no longer matches any char - wget -T 5 prevents indefinite hang on slow or stuck endpoint
|
@silent-cipher @juliangruber this is a fairly lightweight PR, can I get a review? |
silent-cipher
left a comment
There was a problem hiding this comment.
Looks good to me.
I’m not deeply familiar with the kustomize/local yaml setup, but nothing stood out as concerning.
fix on top of #438 to ensure local cluster waits on postgres and clickhouse pods