Skip to content

Update AbstractContainer get method return type #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jdiazromeral wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update AbstractContainer get method return type #29

jdiazromeral wants to merge 1 commit into from

Conversation

@jdiazromeral
Copy link

@jdiazromeral jdiazromeral commented Jul 2, 2025

Update the return type for the get method in AbstractContainer and its implementation to improve type flexibility.

The change replaces Optional[object] with Any as both get and _do_get methods depends on __instance_from_fqn method which returns Any type.

@jdiazromeral jdiazromeral self-assigned this Jul 2, 2025
@jdiazromeral jdiazromeral requested a review from a team as a code owner July 2, 2025 09:23
@jdiazromeral jdiazromeral requested review from acrusella and removed request for a team July 2, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acrusella acrusella Awaiting requested review from acrusella acrusella is a code owner automatically assigned from Feverup/platform

Assignees

@jdiazromeral jdiazromeral

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jdiazromeral