spark: fallback to WebSocket on X1 HTTP auth failure and improve SPARK_API_PASSWORD handling#5
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for goodaction-hub ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SPARK_API_PASSWORDto avoid accidental misconfiguration.Description
SPARK_API_PASSWORDto useprocess.env.SPARK_API_PASSWORD || process.env.IFLYTEK_SPARK_API_PASSWORDand apply.trim()to the value.HttpErrorLike,getHttpStatus, andshouldFallbackToWshelpers to extract HTTP status and decide fallback conditions.chatSparkX1Httpattach astatusandnameto thrown errors when the HTTP response is not ok.chatSparktotrythe X1 HTTP path and on401/403automatically log a warning and fall back tochatSparkWswhen WS credentials (APP_ID,API_KEY,API_SECRET) are available, otherwise rethrow the HTTP error.Testing
tscwhich completed successfully.npm testand the tests passed successfully.Codex Task