Strip system-reminder blocks before smart tool selection classification #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The CLI injects <system-reminder> blocks into user messages containing
keywords like "search", "explain", and "documentation". The smart selection
classifier was scanning the full message content including these injected blocks,
causing it to misclassify requests based on keywords that the user never typed.
For example, a simple greeting could be classified as a "research" request
because the system-reminder block contained the word "search".
Changes implemented:
1. System-reminder stripping (src/tools/smart-selection.js)
- Added pre-compiled SYSTEM_REMINDER_PATTERN regex to match
<system-reminder>...</system-reminder> blocks
- Strip these blocks from message content before running classification
- Pattern is compiled once at module load for performance
- Only affects classification input; original message is unchanged
Testing:
- Messages with system-reminder blocks now classify based on actual user content
- Simple greetings no longer misclassified as research/coding requests
- Messages without system-reminder blocks behave identically to before
- npm run test:unit passes with no regressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
<system-reminder>blocks from user messages before running the smart tool selection classifierProblem
The CLI injects
<system-reminder>blocks into user messages containing keywords like "search", "explain", and "documentation". The smart selection classifier scans the full message content including these injected blocks, causing misclassification based on keywords the user never typed. For example, a simple greeting could be classified as a "research" request because the system-reminder contained the word "search".Changes
SYSTEM_REMINDER_PATTERNregex; strip matched blocks from content before classification inclassifyRequestType()Testing
npm run test:unitpasses with no regressions