-
Notifications
You must be signed in to change notification settings - Fork 2
feat: normalize numeric formatting & add time-range selector for usage trends (sanitization fix) #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Fail-Safe
wants to merge
7
commits into
main
Choose a base branch
from
feat/formatting-normalization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: normalize numeric formatting & add time-range selector for usage trends (sanitization fix) #60
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cc7f0ba
feat: normalize numeric formatting & time-range selector to clamp dec…
Fail-Safe 0799863
fix: remove unnecessary async/await from archiveOldData to satisfy li…
Fail-Safe be12b8e
fix: address lint warnings - remove unused spendData and prefix unuse…
Fail-Safe 28261d0
fix: remove unused parameter from inferAnomalyCause and update callers
Fail-Safe 3d45c75
fix(webview): sanitize dynamic HTML using escapeHtml to prevent XSS/c…
Fail-Safe e209a04
chore(ci): re-run CodeQL
Fail-Safe 0f3ba70
chore(ci): re-run CodeQL
Fail-Safe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Client-side cross-site scripting High
Copilot Autofix
AI about 2 months ago
To fix the DOM-based XSS vulnerability, all instances where untrusted data is inserted into HTML must be properly escaped before being included in HTML strings set via
innerHTML. In this case, the affected code is in therenderMultiMonthAnalysisfunction, especially where values from theanalysisobject (ultimately fromevent.data) are interpolated into thehtmlstring.The safest and least intrusive fix is to create a reusable HTML-escaping function, such as
escapeHtml, and apply it to any untrusted values inserted into the HTML string. This method leaves all layout and logic unchanged, only ensuring that inserted content cannot break HTML context or inject scripts. TheescapeHtmlfunction can be added near the top of the module, or immediately before its first use.Approach
escapeHtml(str)) that escapes<,>,&,",', and`.renderMultiMonthAnalysis, wrap all instances ofanalysis.dataMonths(and any other untrusted values) insideescapeHtml(String(...))when interpolating into the HTML string.