fix: create prompt file when both automatic review flags are set#70
Merged
shashank-factory merged 1 commit intodevfrom Apr 1, 2026
Merged
Conversation
When both automatic_review and automatic_security_review were true, prepareTagExecution returned early without calling prepareReviewMode, so no prompt file was written. The Droid Exec step then failed with 'Prompt file does not exist'. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Contributor
|
Droid finished @factory-nizar's task —— View job Droid reviewed PR #70 and found no actionable bugs. Both candidate comments were rejected during validation — one was speculative about pre-existing architectural design (parallel security review jobs), and the other had an invalid diff anchor on unchanged code. The fix correctly resolves the missing prompt file issue. |
shashank-factory
approved these changes
Apr 1, 2026
![factory-droid[bot]](https://avatars.githubusercontent.com/in/358017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The fix correctly routes the dual-flag case through prepareReviewMode() to create the prompt file, resolving the runtime failure. The run_security_review output flag is preserved for downstream parallel job handling, consistent with the pre-existing architecture. No actionable bugs found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When both
automatic_review: trueandautomatic_security_review: trueare set,prepareTagExecution()returned early without creating a prompt file, causing the "Run Droid Exec" step to fail with:Repro: https://github.com/Factory-AI/factory-mono/actions/runs/23825974314/job/69449081451
The early return was left by a "parallel mode" design (separate jobs for code review and security review) that was never implemented. The
action.ymlis a single composite action with no step that readsrun_security_review, so the early return just skipped prompt creation and nothing picked up the slack.Fix
When both flags are set, call
prepareReviewMode()instead of returning early. This creates the prompt file and runs code review normally. Therun_security_reviewoutput is still set but has no effect since no step inaction.ymlconsumes it -- security review was never running in this configuration anyway.