fix(cli): Security review plugins prompt update#68
Merged
shashank-factory merged 1 commit intodevfrom Mar 31, 2026
Merged
Conversation
Contributor
|
Droid finished @shashank-factory's task —— View job |
Contributor
|
Droid finished @shashank-factory's task —— View job |
factory-nizar
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the security review plugin prompt to automatically generate a threat model when one is missing, instead of simply noting its absence, and adds handling for stale threat models.
Changes
.factory/threat-model.mddoes not exist, the prompt now instructs Droid to invoke the threat-model-generation skill to create one and use it as context, rather than deferring generation to a separate process.Implementation Details
Single file change in
src/create-prompt/templates/security-review-prompt.ts, modifying the "Step 1: Threat Model Check" section of the security review prompt template (+3 / −2 lines).Testing
[To be filled by author]
Related Issues
[To be filled by author]