Skip to content

fix(cli): Security review plugins prompt update#68

Merged
shashank-factory merged 1 commit intodevfrom
ssharma/security-review-plugin-2
Mar 31, 2026
Merged

fix(cli): Security review plugins prompt update#68
shashank-factory merged 1 commit intodevfrom
ssharma/security-review-plugin-2

Conversation

@shashank-factory
Copy link
Copy Markdown
Contributor

@shashank-factory shashank-factory commented Mar 31, 2026

Summary

Updates the security review plugin prompt to automatically generate a threat model when one is missing, instead of simply noting its absence, and adds handling for stale threat models.

Changes

  • Auto-generate missing threat models: When .factory/threat-model.md does not exist, the prompt now instructs Droid to invoke the threat-model-generation skill to create one and use it as context, rather than deferring generation to a separate process.
  • Stale threat model handling: Added a new condition for threat models older than 90 days — the prompt notes them as potentially stale but proceeds with the existing file.
  • Clarified existing model path: The "exists and current" case is now explicitly labeled for clarity.

Implementation Details

Single file change in src/create-prompt/templates/security-review-prompt.ts, modifying the "Step 1: Threat Model Check" section of the security review prompt template (+3 / −2 lines).

Testing

[To be filled by author]

Related Issues

[To be filled by author]

@factory-droid
Copy link
Copy Markdown
Contributor

factory-droid bot commented Mar 31, 2026

Droid finished @shashank-factory's task —— View job


@factory-droid
Copy link
Copy Markdown
Contributor

factory-droid bot commented Mar 31, 2026

Droid finished @shashank-factory's task —— View job


@shashank-factory shashank-factory merged commit 5f05d53 into dev Mar 31, 2026
4 checks passed
@shashank-factory shashank-factory deleted the ssharma/security-review-plugin-2 branch March 31, 2026 20:31
Copy link
Copy Markdown
Contributor

@factory-droid factory-droid bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates the security review prompt to generate a threat model when missing and to flag potentially stale ones. No high-confidence correctness or security issues were found in the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants