Merged
Conversation
Contributor
|
Droid finished @shashank-factory's task —— View job |
Contributor
|
Droid finished @shashank-factory's task —— View job Security Review Plugin PR — Validation Complete Reviewed 2 candidate comments from Phase 1. Both were rejected as speculative best-practice suggestions rather than definite runtime bugs — the graceful-continue-on-failure pattern is intentional and matches the prior implementation. No inline comments posted. PR review summary submitted. |
varin-nair-factory
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the manual security skills installation process with the new
droid pluginCLI, switching from a git-clone-and-copy approach to thesecurity-engineer@factory-pluginsmarketplace plugin.Changes
action.yml: Replaced the ~50-line "Install Security Skills" step (sparse git clone, per-skill copy, verification loop) with a 3-line "Install Security Plugin" step usingdroid plugin marketplace addanddroid plugin install security-engineer@factory-plugins --scope user.security/action.yml: Applied the same simplification to the standalone security action, reducing ~25 lines of shell to the same plugin install commands.src/create-prompt/templates/security-report-prompt.ts: Updated the "Security Skills Available" section to reference the plugin source (security-engineer@factory-plugins) instead of the local~/.factory/skills/directory.src/create-prompt/templates/security-review-prompt.ts: Same prompt reference update as above.Implementation Details
The previous approach cloned
Factory-AI/skillswith a sparse checkout, copied four individual skill directories (threat-model-generation,commit-security-scan,vulnerability-validation,security-review) into~/.factory/skills/, and ran a multi-step verification. The new approach delegates all of this to thedroid pluginCLI, which handles marketplace registration, download, and installation in two commands. Both action files include graceful fallback warnings if the plugin install fails.Testing
[To be filled by author]
Related Issues
[To be filled by author]