Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
ishaankalra
force-pushed
the
azure-modules-revamp
branch
from
dd7b0f7 to
3f3135d
Compare
| resource_type: network | ||
| resource_name: default | ||
| cloud_account: | ||
| type: '@outputs/cloud_account' |
There was a problem hiding this comment.
use flavor specific cloud account
| providers: | ||
| - azurerm | ||
| outputs: | ||
| default: |
There was a problem hiding this comment.
use the attributes/interfaces output name instead of default
ishaankalra
force-pushed
the
azure-modules-revamp
branch
from
3f3135d to
9415a95
Compare
| flavor: azure_aks_cluster | ||
| alias-flavors: | ||
| - default | ||
| version: '0.2' |
There was a problem hiding this comment.
lets have a different flavor and version so that exsiting modules won't get an upgrade option
| description: Configuration for the AKS cluster. | ||
| x-ui-toggle: false | ||
| properties: | ||
| kubernetes_version: |
There was a problem hiding this comment.
Lets keep auto upgrade by default and remove this attribute.
| - authenticator | ||
| - controllerManager | ||
| - scheduler | ||
| sku_tier: |
There was a problem hiding this comment.
just review the attributes once whether it should be overrides only or overrides disabled
| x-ui-overrides-only: true | ||
| x-ui-error-message: CIDR must be a valid IP block (e.g., 10.0.0.0/16) | ||
| x-ui-placeholder: 10.0.0.0/16 | ||
| region: |
There was a problem hiding this comment.
use the dropdown to select region
| title: Azure Region | ||
| description: Azure region where the VNet will be created | ||
| x-ui-overrides-only: true | ||
| availability_zones: |
There was a problem hiding this comment.
use the dropdown to azs based on region
| type: string | ||
| minItems: 1 | ||
| maxItems: 3 | ||
| use_fixed_cidr_allocation: |
There was a problem hiding this comment.
what is the use of this?
| - '1024' | ||
| - '2048' | ||
| - '4096' | ||
| - '8192' |
There was a problem hiding this comment.
use a /16 cidr and use the max in each type of subnets
| default: single | ||
| required: | ||
| - strategy | ||
| private_endpoints: |
There was a problem hiding this comment.
try and see if we can have additional custom endpoints can be passed?
| outputs: | ||
| default: | ||
| type: '@facets/azure-network-details' | ||
| sample: |
There was a problem hiding this comment.
only keep the mandatory fields in the sample
3 participants
Description
Related issues
Type of change
Checklist
developbranchTesting
Reviewer instructions