Add join variants and examples#3
Open
dzmitry-lahoda wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 434cf0770b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9a804ce to
b9a05af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
Based on #2
Assuming it is not possible to make rows_number nice enough to use #5
Summary
Adds join and positional pairing variants to OQL:
join_must: inner equality join that panics when an outer row has no matching inner row.join_left: left equality join that keeps unmatched outer rows and projects joined fields asOptionvalues.last_must: fast must-match join that keeps only the last inner row per key, avoiding per-key match vectors when only the final match is needed.zip: positional pairing that matches RustIterator::zipand stops when either side ends.zip_must: positional pairing that panics if the two sources have different lengths.Also adds regression coverage for left-join field rewriting through
letbindings and nested method receivers, plus dedicatedzip.rstests, docs, and UI snapshot updates.Validation
cargo fmtcargo test -p oql --test zipcargo test -p oql