Conversation
fix: resolve rustfmt and clippy CI failures
fix: allow merge commits in conventional commits validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request mainly refactors code for improved readability and consistency across several modules, especially in the
CheckRunnerandGithubClientimplementations. The changes focus on formatting, simplifying expressions, and minor logic improvements, without altering core functionality.Minor Logic Improvements
strip_prefixin theis_conventional_commitfunction for better clarity and correctness.Consistency in Function Signatures
failedandwarninginCheckResultto use single-line formatting, improving consistency and reducing vertical space.Simplification of Data Processing
GithubClient::fetch_file_contentby using a more concise method to remove unwanted characters.Minor Refactoring in Check Engine
CheckEnginefor filtering passed and warning statuses, and improved formatting for the date string assignment.