lib: add missing hook_unregister_arg in mgmt_be_client_destroy (backport #21940)#21944
Merged
Merged
Conversation
mgmt_be_client_create() registers a hook on nb_notification_tree_send but mgmt_be_client_destroy() never unregisters it. During shutdown, the client struct gets freed while the hook still points to it. When the subscription wheel timer fires after that, it dispatches to mgmt_be_send_notification() with the freed pointer and crashes. ZEBRA: Received signal 11 (si_addr 0x108000001d0) libfrr.so.0(nb_notification_tree_send+0x69) libfrr.so.0(nb_notification_send+0x165) libfrr.so.0(nb_notify_subscriptions+0xb8) libfrr.so.0(event_call+0x81) in thread wheel_timer_thread scheduled from ../lib/wheel.c:50 Fix by adding hook_unregister_arg() before freeing the client. Signed-off-by: Rajesh Varatharaj <rvaratharaj@nvidia.com> (cherry picked from commit 89c4433)
|
Target branch is not in the allowed branches list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
mgmt_be_client_create() registers a hook on nb_notification_tree_send but mgmt_be_client_destroy() never unregisters it. During shutdown, the client struct gets freed while the hook still points to it. When the subscription wheel timer fires after that, it dispatches to mgmt_be_send_notification() with the freed pointer and crashes.
Fix by adding hook_unregister_arg() before freeing the client.
Signed-off-by: Rajesh Varatharaj rvaratharaj@nvidia.com
This is an automatic backport of pull request #21940 done by Mergify.