-
Notifications
You must be signed in to change notification settings - Fork 0
vision logging #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Levercpu
wants to merge
25
commits into
main
Choose a base branch
from
LS_Vision_Simulation_+Logging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
vision logging #85
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
88b1f69
initial commit
Levercpu 1781c98
initial commit
Levercpu 16ab803
initial commit
Levercpu f244dae
initial commit
Levercpu 370ea9a
merge main
Levercpu c0ae709
merge main
Levercpu 2c7560a
most pr comments addressed
Levercpu 4e2456f
Merge branch 'main' of https://github.com/FRC4048/Java_2026 into LS_V…
Levercpu 50d395e
all addressed or comment or question
Levercpu d449065
Merge branch 'LS_Vision_Simulation' of https://github.com/FRC4048/Jav…
Levercpu e059a2f
pr comments fixed.
Levercpu 49f822e
fixed pr comments
Levercpu 5754b46
only way to not thrown null pointer
Levercpu 13430c6
Merge branch 'LS_Vision_Simulation' of https://github.com/FRC4048/Jav…
Levercpu bd2fac0
small logging change
Levercpu c4a51e7
Merge branch 'main' of https://github.com/FRC4048/Java_2026 into LS_V…
Levercpu 1bb160f
Merge branch 'main' of https://github.com/FRC4048/Java_2026 into LS_V…
Levercpu 382f6b6
Merge branch 'LS_Vision_Simulation' of https://github.com/FRC4048/Jav…
Levercpu a29d956
Merge branch 'main' of https://github.com/FRC4048/Java_2026 into LS_V…
Levercpu a47b8f7
fixed
Levercpu 76bf35f
fixed
Levercpu 66f7fd9
fixed
Levercpu 5c60892
wip
Levercpu cdde152
wip
Levercpu e11869c
done
Levercpu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/main/java/frc/robot/subsystems/swervedrive/vision/truster/VisionMeasurement.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,12 @@ | ||
| package frc.robot.subsystems.swervedrive.vision.truster; | ||
|
|
||
| import edu.wpi.first.math.geometry.Pose2d; | ||
| import frc.robot.utils.Apriltag; | ||
|
|
||
| /** | ||
| * @param measurement estimated robot position (meters) calculated from apriltag tag what tag produced the | ||
| * position | ||
| * @param distanceFromTag distance (meters) estimated robot pose was from the tag | ||
| * @param timeOfMeasurement time when the pose was measured (seconds) | ||
| */ | ||
| public record VisionMeasurement( | ||
| Pose2d measurement, double distanceFromTag, double timeOfMeasurement) {} | ||
| public record VisionMeasurement(Pose2d measurement, double distanceFromTag, double timeOfMeasurement) {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious to see whether this contains any non-zero values - AFAICT, the simulation pose is only applicable in simulation and the real pose is only available in non-simulation, so when would we be able to compare them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the getpose is the estimated pose from the vision measurements and drift adjusted odometry (trying to model real life performance)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getPoseisswerveDrive.getPose(), which is the combined vision and odometry.swerveDrive.getSimulationDriveTrainPose()is the pose during simulation. What does the difference between them tell us?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the getpose has simulated error added on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put in wrapper kept for now