Version 1 #4
Open
Version 1 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tortuga-AM
reviewed
Oct 20, 2025
Collaborator
Tortuga-AM
left a comment
Tortuga-AM
left a comment
There was a problem hiding this comment.
Well done! Overall really good. Left a couple style changes or recommendations. No need to implement them just for reference.
| */ | ||
| public static int[] fizzbuzz(int[] arr) { | ||
| return null; | ||
| int [] array = {0, 0, 0}; |
Collaborator
There was a problem hiding this comment.
Common practice is int[]
| return null; | ||
| int [] array = {0, 0, 0}; | ||
| for (int num : arr) { | ||
| if (num % 3 == 0 && num % 5 == 0) { |
Collaborator
There was a problem hiding this comment.
Recommend more parentheses for clarity
| // Your code goes here | ||
| return false; | ||
| boolean prime = true; | ||
| for (double i = 2; i <= Math.sqrt(n); i++) { |
| boolean prime = true; | ||
| for (double i = 2; i <= Math.sqrt(n); i++) { | ||
| if (n % i == 0) { | ||
| prime = false; |
Collaborator
There was a problem hiding this comment.
You can return prime here because you know it's value
Comment on lines
62
to
66
| boolean cd1 = false; | ||
| boolean cd2 = false; | ||
| boolean cd3 = false; | ||
| boolean cd4 = false; | ||
| boolean cdLength = false; |
Collaborator
There was a problem hiding this comment.
Recommend better variable names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version 1