Skip to content

fix(#150): auto-register HEAD route for GET routes#157

Closed
weilixiong wants to merge 2 commits into
FOSSFORGE:mainfrom
weilixiong:main
Closed

fix(#150): auto-register HEAD route for GET routes#157
weilixiong wants to merge 2 commits into
FOSSFORGE:mainfrom
weilixiong:main

Conversation

@weilixiong

@weilixiong weilixiong commented May 17, 2026

Copy link
Copy Markdown

Fix #150\nAuto-register HEAD route when GET route is registered.\n\n## Fix #151\nSuppress response body in send() when request method is HEAD (RFC 9110 §9.3.2).

@coderabbitai

coderabbitai Bot commented May 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 542600b8-6bd8-4ceb-9c8d-40b914d2a308

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@weilixiong

Copy link
Copy Markdown
Author

Hi, this PR addresses #150 (auto-register HEAD for GET routes) and #151 (suppress body for HEAD). The HEAD body fix follows RFC 9110 §9.3.2 — empty body sent when method is HEAD. Would appreciate a review.

@VikramAditya33

Copy link
Copy Markdown
Collaborator

Please reduce down the scope of PR to #151 only. Thank you

@VikramAditya33

Copy link
Copy Markdown
Collaborator

superseded by #152 and #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Response body not suppressed for HEAD requests HEAD requests to GET-only routes return 404

2 participants