API App #141
Draft
API App #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to filter response
adityacp
reviewed
May 29, 2020
api/views.py
Outdated
| if params.get('status', None): | ||
| try: | ||
| queryset = queryset.filter(status=params.get('status')) | ||
| except: |
Contributor
There was a problem hiding this comment.
you don't need the try-except anywhere if filter query is not successful it won't throw any error
adityacp
reviewed
May 29, 2020
api/views.py
Outdated
| pass | ||
| if params.get('date_from'): | ||
| try: | ||
| queryset = queryset.filter(date__gte=dateutil.parser.parse(params.get('date_from')).date()) |
Contributor
There was a problem hiding this comment.
You don't need to do any parse here. If the date is not proper the filter will return empty.
techievivek
reviewed
Jun 19, 2020
techievivek
left a comment
techievivek
left a comment
There was a problem hiding this comment.
We will need the instructor username so please update this.
|
|
||
| class WorkshopSerializer(serializers.ModelSerializer): | ||
| workshop_type = WorkshopTypeField(read_only=True) | ||
|
|
There was a problem hiding this comment.
We need the instructor name, not the id so, please add this line of code here
instructor=serializers.StringRelatedField(many=False)
I have tested it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added API app