Sample dproj search paths: kb, markdown, identity, session, memory/localvector parity with main dproj#235
Open
FMXExpress wants to merge 1 commit into
Open
Conversation
…calvector Likely follow-up to the Codex review on PR #234 (couldn't read the review-comments content due to a persistent GitHub API rate-limit on that endpoint, but the broader inconsistency was visible from the diff context). PR #234 fixed the missing src/pkg/shell entry in the sample dprojs/cfgs/Makefile but five other directories were already missing the same way: - kb - markdown - identity - session - memory/localvector These exist in the main dproj's DCC_UnitSearchPath but not in the sample component-console dprojs. Any sample that pulls PasClaw.Config transitively (which all three do via PasClaw.Component) would F2613 on a `uses` chain crossing those paths on dcc64. Brought all five into parity across: - samples/component-console/SampleServer.dproj - samples/component-console/SampleConsole.dproj - samples/component-console/SampleSimple.dproj - samples/component-console/dcc32.cfg + dcc64.cfg - samples/component-console/Makefile FPC make smoke + full make test green (FPC was unaffected, repo-root Makefile is independent). https://claude.ai/code/session_01TBcLtmpj7dqA5tyFbGnQon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Likely follow-up to the Codex review on PR #234. Caveat: I couldn't read the actual inline review-comments content — the GitHub
get_review_commentsendpoint was persistently rate-limited across ~7 retries spanning ~30 minutes (other endpoints worked). I can see Codex submitted aCOMMENTEDreview on commite32305ebut not the body. Inferring the likely concern from the diff context: PR #234 fixedshellin the sample dprojs but five other directories were already missing the same way.Missing paths
The main
src/pasclaw/PasClaw.dproj'sDCC_UnitSearchPathhad these; the sample dprojs/cfgs/Makefile didn't:kbmarkdownidentitysessionmemory\localvectorAny sample that pulls in
PasClaw.Configtransitively (all three do, viaPasClaw.Component) would hitF2613 Unit not foundon auseschain crossing those paths on dcc64 — exactly the failure mode PR #234 fixed forshell.Files updated
samples/component-console/SampleServer.dprojsamples/component-console/SampleConsole.dprojsamples/component-console/SampleSimple.dprojsamples/component-console/dcc32.cfgsamples/component-console/dcc64.cfgsamples/component-console/MakefileTest plan
make smokeclean (FPC unaffected — the repo-root Makefile is independent and already had these paths).make testgreen (35 targets).PasClaw.KB.*,PasClaw.Markdown.*,PasClaw.Identity,PasClaw.Session.*,LocalVector.*should clear.If Codex's actual review was about something different, let me know and I'll address it on a separate PR — happy to take direction once I can see the inline content.
https://claude.ai/code/session_01TBcLtmpj7dqA5tyFbGnQon
Generated by Claude Code