Add MemCard Pro GC Support#1125
Conversation
Uses code from the swiss implementation emukidid/swiss-gc@3ee5c03
|
Any reason why this PR hasn't been accepted and merged into master with a new official build yet? |
|
@carnage702 do you have the ability to merge this? |
|
@FIX94 bump |
|
@DDRBoxman Has this been tested recently? I compiled it and it generates a new memory card file on the memcardpro but the filename is corrupt and it throws an error on the memory card |
if this is true i wont merge it, i dont have it to test it. |
| strncpy(ncfg->GamePath, StartChar, sizeof(ncfg->GamePath)); | ||
| ncfg->GamePath[sizeof(ncfg->GamePath)-1] = 0; | ||
| memcpy(&(ncfg->GameID), gi[SelectedGame].ID, 4); | ||
| memcpy(&(ncfg->GameMakerCode), gi[SelectedGame].MakerCode, 2); |
There was a problem hiding this comment.
@DDRBoxman Before this memcpy of two bytes to GameMakerCode, should the full four bytes of this unsigned int be set to 0 so that the other two bytes aren't random uninitialized bytes?
ncfg->GameMakerCode = 0
memcpy(&(ncfg->GameMakerCode), gi[SelectedGame].MakerCode, 2);
4 participants
Uses code from the swiss implementation:
emukidid/swiss-gc@3ee5c03
#1045