Add tests to each component#21
Conversation
biankaiwen111
requested review from
a team,
AmberWow123,
ak840206 and
kis87988
as code owners
|
Current codeclimate issues could be ignored and will be resolved by |
|
we may want to use an env file to define absolute path to src folder and log folder |
hk-mp5a3
left a comment
hk-mp5a3
left a comment
There was a problem hiding this comment.
LGTM, approved.
If it is possible, try to make the change(PR) as small as possible. It would be more readable for code reviewers to review your code.
|
Review is temporary on hold until |
|
I should be should be able to put all |
kis87988
left a comment
kis87988
left a comment
There was a problem hiding this comment.
must of part LGTM.
this PR needs to be rebased since that is password in the first commit#775d74a
and let's get start with dotenv implementation
…atible with new crawled data
yifeili98
left a comment
yifeili98
left a comment
There was a problem hiding this comment.
Please git rm src/FHDAlogger.py, src/__init__.py, src/course_pb2.py, src/department_pb2.py and src/instructor_pb2.py
yifeili98
left a comment
yifeili98
left a comment
There was a problem hiding this comment.
LGTM, but you could add more descriptions to let reviewers know what features/refactors you have done in this PR.
5 participants
No description provided.