Skip to content

create_archive function#35

Open
andreaa93 wants to merge 1 commit intomainfrom
34-create-archive-function
Open

create_archive function#35
andreaa93 wants to merge 1 commit intomainfrom
34-create-archive-function

Conversation

@andreaa93
Copy link
Copy Markdown
Collaborator

dict_nan_equal is checking if two dicts are equal, ignoring any NaN value.

This is necessary because in Python it is always NaN != Nan

@andreaa93 andreaa93 linked an issue Feb 23, 2024 that may be closed by this pull request
@andreaa93
Copy link
Copy Markdown
Collaborator Author

BTW, I'm getting a different error when reprossing for the second time. It is something connected to the normalization of the EntityReference class. It is not finding anymore the context of the referenced Entry. I'll check it

@ka-sarthak
Copy link
Copy Markdown
Collaborator

I recently created entries in the nomad-polymerization-reactions plugin by creating archive.yaml files and adding them to the upload folder. The nomad parser can then make the entries for us. Regarding overwriting, we can put some logic for updating the archive.yaml files rather than the entries. I think @hampusnasstrom also had a similar idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create archive function

2 participants