Conversation
|
🤖 Hi @JFRudzinski, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
@DanielYang59 Before I send to others for review, could you please assess my overall approach here, provide feedback on the code, especially the github workflow which I have not tested yet. |
|
|
Thank you @lukaspie and @ahm531 for the feedback. Below I address individual comments and note changes so far: From @lukaspie:
Done. (According to Ahmed's suggestion)
Done.
I don't really have a strong opinion myself on this myself. I see that at the moment they are not very useful, but perhaps in the future they are more indicative of usage? I left them now for further comments from others.
Can you explain why you don't like 2 separate categories? This is well-defined in GitHub. For me the author list is for acknowledgement. The maintainer list for contact. It is also mentioned at the top of the page that FAIRmat owns and maintains all these plugins. Perhaps that should be made clearer. Usage of "The NOMAD Authors" appears to be largely used by nomad-coe plugins which are or will eventually be archived.
The issue of maintaining author lists is independent of this page. But I think it is something that we want to do, at least while FAIRmat exists, as it is a major way we can acknowledge our co-workers work, through publications of repos on Zenodo.
I am fine with this but some plugins have many entry points which will blow up the text a little. I like the way Ahmed did it cause the Plugin Types are in the overview, and the detailed list only in the drop down. Also, often the type is also in the entry point name, as in the example you gave. I am open to more opinions on this though.
👍
Done. (There is a check that only opens a PR if changes are found, so this should have no negative side effect).
Yes, but let's finalize the format first.
From @ahm531 I took the format suggestions from |
|
Oh .. The location of the page let's discuss later |
I think it's fine to have both categories, as long as we agree to fill these correctly. That means to me that we do not use "The NOMAD authors", but highlight the actual people who did the work and who are the maintainers. For now, the categories are pretty redundant if they just contain these generic placeholders in both categories. But okay, let's keep and make it a separate point to acknowdledge properly. I think the main issue is the inconsistent use of authors and maintainers in On a separate note, the maintainers category may be tricky because these get outdated with coworkers leaving.
agree
agree, I like Ahmed's solution |
|
One more thing that I forgot (maybe it was already discussed, if so, please ignore): would it be possible to have at the top of the plugins overview the possiblity to filter by entry point? So e.g., all NORTH tools or all Parsers could be shown? Or do we let the |
|
I do think that having the list of plugins cleanly in very clear webpage is a good idea. To me this also feels much more natural than having a separate app for plugins. Although functionality-wise the app is great, it is very hard to justify that approach because it is too tighlty coupled to a deployment and requires quite a bit of mental overhead to understand for new people ("I'm now in a NOMAD deployment, which has a NOMAD App that showcases NOMAD plugins." vs. "I'm now reading the NOMAD docs and looking at a list of plugins"). Functionality-wise and visually this can certainly be improved (I would ask Berfin about the visuals), but I think there are more fundamental questions:
|
Based on these comments, I think there are some fundamental design choices to discuss. I will arrange a dedicated meeting for this. |
* collecting material first * working on the description of the tools * updates * add context and explanation for further tools * done with walking through all containers, past and present ones * initial proof-reading, needs feedback now * work in feedback from the last tf meeting, work on previously untouched footer and header sections, reduce reporting of the history behind the tools, mark for each tool what should happen to these and where that tool-specific part of the documentation should go * typos, a proof-reading round, ready for review * add connection to #186 plugin registry page * worked in comments from lukaspie * remaining reviewer comment --------- Co-authored-by: mkuehbach <markus.kuehbach@physik.hu-berlin.de>
* collecting material first * working on the description of the tools * updates * add context and explanation for further tools * done with walking through all containers, past and present ones * initial proof-reading, needs feedback now * work in feedback from the last tf meeting, work on previously untouched footer and header sections, reduce reporting of the history behind the tools, mark for each tool what should happen to these and where that tool-specific part of the documentation should go * typos, a proof-reading round, ready for review * add connection to #186 plugin registry page * worked in comments from lukaspie * remaining reviewer comment --------- Co-authored-by: mkuehbach <markus.kuehbach@physik.hu-berlin.de>
|
I just came across this, we should probably remove it as well or link to the plugin navigation page instead: https://nomad-lab.eu/prod/v1/docs/howto/plugins/types/schema_packages.html#schema-packages-developed-by-fairmat |
|
@DanielYang59 I merged develop into this branch, and now I get a ton of warnings when I do mkdocs serve which I guess are coming from the changes from removing the example data maybe. Have you seen this? Can you check it for me? |
|
TODOs:
|
Can you show me the warnings you got? I only saw some deprecation warnings from fastapi side but was fixed in https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR/-/merge_requests/2836 |
|
yeah same: but also these files not in nav. I guess maybe I messed up the merge? |
|
I think there're two separate warnings here:
You could run |

Add Automated NOMAD Plugin Registry
This PR implements an automated plugin registry documentation page that queries and displays all NOMAD plugins from the FAIRmat-NFDI and nomad-coe GitHub organizations.
Features
nomad-pluginsapp for plugin metadataImplementation
New Files:
scripts/generate_plugin_registry.py- API query and markdown generation script.github/workflows/update-plugin-registry.yml- Monthly automation workflowdocs/examples/plugin_registry.md- Generated registry pagescripts/README.md- Script documentationWorkflow:
Manual regeneration: