Open
Conversation
biotek.py is not parsing a file correctly. I am uploading the problematic file and adding a test to show the problem.
I modified the biotek.py file to search for the text "start kinetic" in the first column of the Excel file. This is how the Gen5 software defines kinetic reads. Then parse the data in the next cell to the right to get the interval information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The read_biotek function failed to parse my Gen5 data file "gen5_data_export_test_12-1-2025.xlsx" due to hardcoded measurement interval locations.
Solution:
I modified read_biotek to search for 'Start Kinetic' entries in column A and extract the measurement interval dynamically from the adjacent column, providing more robust parsing.
Testing: