Improve beam weapon economy drain#7122
Draft
lL1l1 wants to merge 1 commit into
Draft
Conversation
Allows high cost + high drain beams to be powered off of stored energy
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Allows high cost + high drain beams to be powered off of stored energy. Also prevents energy stalls from a beam firing when you have high income but low energy trend.
Testing done on the proposed changes
Novax satellite with 72k energy requirement and 5000 energy drain can fire off of 4 storages (40k e) + adjacent t3 pgen (3125 e/s).
I went through usages of the function and didn't see any functional part that would cause the beam to stop mid-way through the firing stage.
There is a bug where waiting for drain cancels a firing tick because default fire ready state has no transition to fire state after waiting for econ drain.
Checklist