Skip to content

Improve beam weapon economy drain#7122

Draft
lL1l1 wants to merge 1 commit into
FAForever:developfrom
lL1l1:improve-beam-weapon-check
Draft

Improve beam weapon economy drain#7122
lL1l1 wants to merge 1 commit into
FAForever:developfrom
lL1l1:improve-beam-weapon-check

Conversation

@lL1l1
Copy link
Copy Markdown
Contributor

@lL1l1 lL1l1 commented May 17, 2026

Description of the proposed changes

Allows high cost + high drain beams to be powered off of stored energy. Also prevents energy stalls from a beam firing when you have high income but low energy trend.

Testing done on the proposed changes

Novax satellite with 72k energy requirement and 5000 energy drain can fire off of 4 storages (40k e) + adjacent t3 pgen (3125 e/s).
I went through usages of the function and didn't see any functional part that would cause the beam to stop mid-way through the firing stage.

There is a bug where waiting for drain cancels a firing tick because default fire ready state has no transition to fire state after waiting for econ drain.

Checklist

Allows high cost + high drain beams to be powered off of stored energy
@lL1l1 lL1l1 added area: sim Area that is affected by the Simulation of the Game feature: weapon firing cycle related to the weapon firing cycle labels May 17, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 17, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f76184b8-745f-422b-8340-cd09290dd86c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: sim Area that is affected by the Simulation of the Game feature: weapon firing cycle related to the weapon firing cycle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant