Buff Mercy BT#7112
Conversation
Mercies can be a highly effective unit, however their hyper-specialization means that their application is narrow as well, including timeframe usage. It's hard to get enough mercies to make enough impact. It's especially true since big T2 air stage is less common than say big T2 land stage. And by the T3 stage mercies are usually obsolete. All this factors put a big constraint on volume of mercies' production. Current Mercy mass production drain is 7.6 m/s compared to 10.8 m/s when producing beetles (after recent beetle BT nerf). We would reduce BT time 1200-> 800-900. This would put mercies production mass drain one tier above t1/t2 bombers but within the same category as beetles. Making more mercies when needed would allow to spam enough mercies to be and feel impactful on the battlefield without directly buffing the unit itself. Related discord thread: https://discord.com/channels/197033481883222026/1498448334728200382
📝 WalkthroughWalkthroughThis PR applies a balance change to the Mercy unit, reducing its BuildTime economy cost from 1200 to 800, with an accompanying changelog entry documenting the adjustment. The PR also updates deployment metadata to identify the game type as "FAF" with a specific commit hash, and adjusts debug output flags to disable spewing, logging, warnings, and drawing while preserving error reporting. ChangesMercy Unit Balance & Deployment Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
changelog/balance.7112.md (1)
1-1: 💤 Low valueConsider minor grammar improvements for clarity.
The description is clear but could be more polished:
- "to allow spam enough mercies" → "to allow spamming enough Mercies" or "to enable producing more Mercies"
- "to deal impact" → "to make an impact" or "to have meaningful impact"
✍️ Suggested grammar refinements
-- (`#7112`) Mercy receives BT cost reduction to allow spam enough mercies to deal impact on the battlefield. +- (`#7112`) Mercy receives a Build Time reduction to enable producing enough Mercies to make an impact on the battlefield.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@changelog/balance.7112.md` at line 1, Update the changelog entry text "(`#7112`) Mercy receives BT cost reduction to allow spam enough mercies to deal impact on the battlefield." to improve grammar and clarity: replace "to allow spam enough mercies" with either "to allow spamming enough Mercies" or "to enable producing more Mercies" and replace "to deal impact" with "to make an impact" (e.g., "(`#7112`) Mercy receives BT cost reduction to allow spamming enough Mercies to make an impact on the battlefield.").
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lua/shared/components/DebugComponent.lua`:
- Around line 34-38: Revert the debug flag flips in DebugComponent by restoring
the prior default values for EnabledSpewing, EnabledLogging, EnabledWarnings,
and EnabledDrawing (i.e., re-enable them) while keeping EnabledErrors as-is;
find the DebugComponent table/definition that contains the fields
EnabledSpewing, EnabledLogging, EnabledWarnings, EnabledErrors, and
EnabledDrawing and change those four flags back to their previous true/default
settings so this PR only contains balance changes, not global observability
changes.
In `@lua/version.lua`:
- Around line 31-33: The inline comments stating "The use of `'` instead of `\"`
is **intentional**" next to the GameType and Commit declarations (symbols
GameType and Commit) are incorrect and misleading because the code uses double
quotes; remove or update those comments to reflect the actual usage (e.g.,
delete the quote-note or change it to say that double quotes are used
intentionally) so the declaration lines for GameType and Commit match the
comment text.
- Around line 31-33: The PR only updates deployment metadata (GameType and
Commit in lua/version.lua) but does not implement the promised Mercy BuildTime
buff; update the actual unit blueprint instead: locate the Mercy unit definition
(unit blueprint file in units/ or similar containing the Mercy unit's BuildTime
field), change its BuildTime from 1200 to the target 800–900 value, add a short
changelog entry referencing the Mercy BuildTime change, and remove any
accidental CI-only edits to GameType/Commit so the PR contains only functional
changes for the Mercy unit (use symbols: GameType, Commit to identify the
unrelated metadata and the unit blueprint's BuildTime field to apply the fix).
---
Nitpick comments:
In `@changelog/balance.7112.md`:
- Line 1: Update the changelog entry text "(`#7112`) Mercy receives BT cost
reduction to allow spam enough mercies to deal impact on the battlefield." to
improve grammar and clarity: replace "to allow spam enough mercies" with either
"to allow spamming enough Mercies" or "to enable producing more Mercies" and
replace "to deal impact" with "to make an impact" (e.g., "(`#7112`) Mercy receives
BT cost reduction to allow spamming enough Mercies to make an impact on the
battlefield.").
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 43b0913d-b7a2-41cf-b1f4-fc28adb9c213
📒 Files selected for processing (4)
changelog/balance.7112.mdlua/shared/components/DebugComponent.lualua/version.luaunits/DAA0206/DAA0206_unit.bp
Reverse deploy branch leftover after rebase. Restore default
Description of the proposed changes
Mercies can be a highly effective unit, however their hyper-specialization means that their application is narrow as well, including timeframe usage. It's hard to get enough mercies to make enough impact. It's especially true since big T2 air stage is less common than say big T2 land stage. And by the T3 stage mercies are usually obsolete. All this factors put a big constraint on volume of mercies' production.
Current Mercy mass production drain is 7.6 m/s compared to 10.8 m/s when producing beetles (after recent beetle BT nerf). We would reduce BT time 1200-> 800-900. This would put mercies production mass drain one tier above t1/t2 bombers but within the same category as beetles.
Making more mercies when needed would allow to spam enough mercies to be and feel impactful on the battlefield without directly buffing the unit itself.
Additional context
Discord balance thread discussion
Checklist
Summary by CodeRabbit