Open
Conversation
1. add ESD refresh periodic_task 2. fix ESD and l7policy Regex irule configuration conflicts
zhang-shengping
requested review from
Niklaus-xie,
jikui,
zhaoqin-github and
zongzw
zhang-shengping
force-pushed
the
refresh-ESD-9.8-v2
branch
from
c5bf9a8 to
b75510a
Compare
with unit tests
zhang-shengping
force-pushed
the
refresh-ESD-9.8-v2
branch
from
b75510a to
81995bd
Compare
zongzw
reviewed
Jun 10, 2019
zhang-shengping
force-pushed
the
refresh-ESD-9.8-v2
branch
from
22d40b7 to
63fdc37
Compare
zhang-shengping
force-pushed
the
refresh-ESD-9.8-v2
branch
3 times, most recently
from
e05162e to
5a47e1e
Compare
Set 'esd_auto_refresh = False' and use command "neutron lbaas-l7policy-update esd_demo_3 --action REJECT" to trigger ESD file refresh manually.
zhang-shengping
force-pushed
the
refresh-ESD-9.8-v2
branch
from
5a47e1e to
07b6de2
Compare
Niklaus-xie
reviewed
Jun 11, 2019
| # init esd object in service_adapter | ||
| esd_dir = os.path.join(self.get_config_dir(), 'esd') | ||
| esd = EsdTagProcessor(esd_dir) | ||
| # EsdTagProcessor is a singleton, so nothing new |
Contributor
There was a problem hiding this comment.
are you sure this is a singleton?
Contributor
There was a problem hiding this comment.
see line #2412, >1 init_esd() could lead here.
Niklaus-xie
reviewed
Jun 11, 2019
| def update_l7policy(self, old_l7policy, l7policy, service): | ||
| """Update lb l7policy.""" | ||
| if not self.conf.esd_auto_refresh: | ||
| self.init_esd() |
Contributor
There was a problem hiding this comment.
let's discuss the necessity and validity of this part
Contributor
|
should we drop this PR and only review the following one: #1423 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refresh ESD,
restore ESD file and log the error, if an error happens
Set
esd_auto_refresh = Falseand use commandneutron lbaas-l7policy-update esd_demo_3 --action REJECTto trigger ESD file refresh manually.