Fix Matrix.fromColumns column/row indexing and add regression tests#2
Open
Fix Matrix.fromColumns column/row indexing and add regression tests#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Matrix.Companion.fromColumnswas constructing matrices with the wrong index order, causing(row, col)to read from the wrong element of the supplied column vectors.Description
Matrix.Companion.fromColumnsto build entries withcolumns[j][i]so thatmatrix[i, j]equals thei-th element of thej-th input column vector (src/main/kotlin/.../Matrix.kt).fromColumnsKeepsColumnMajorPlacementthat constructs 3 column vectors with distinguishable values (10 * col + row) and assertsmatrix[row, col] == columns[col][row](src/test/kotlin/linear/MatrixTest.kt).fromColumnsKeepsColumnMajorPlacementForRectangularMatrixwhich asserts dimensions and per-element mapping to prevent square-matrix masking of indexing errors (src/test/kotlin/linear/MatrixTest.kt).Testing
sh gradlew test --tests 'linear.MatrixTest', but the Gradle wrapper failed to download due to a network connection error toservices.gradle.org, so tests could not be executed in this environment.Codex Task