feat: variant-specific assets#1037
Merged
MiquelAdell merged 1 commit intodevelopmentfrom Oct 23, 2025
Merged
Conversation
fix: include wmr assets only in wmr variant
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
MiquelAdell
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
This PR allows to configure variant-specific assets to be copied to the public directory.
In this case it fixes the case where wmr specific files were being included in all variants, increasing bundle size with unused unrelated files.
variant-assetsdirectory addedscripts/helpers/variant-assets.ts: allows configuringvariantAssetsConfigto map directories or files that need to be copied fromvariant-assetsto publicscripts/run.ts:build: before build, copy variant assets topublic. After build, cleanup the variant assetsstart-server: before start, copy the assets. Changed to usespawnso process termination can be handled, and files cleaned uppublic/wmrto.gitignoreto make sure the files are not committed in case the cleanup does not complete📹 Screenshots/Screen capture
🔥 Is there anything the reviewer should know to test it?