Feature/add gp check #74
Conversation
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Ramon-Jimenez
left a comment
Ramon-Jimenez
left a comment
There was a problem hiding this comment.
Working great, thanks @gqcorneby !
Waiting on @eperedo feedback before merging
eperedo
left a comment
eperedo
left a comment
There was a problem hiding this comment.
Looks good, just a minor thing about a property possible not being used.
| DataElementsLevelWithValues & { | ||
| result: string; | ||
| child: DataElementWithValue; | ||
| childPrefix: string; |
There was a problem hiding this comment.
Not sure if I'm missing something, but we're not using the childPrefix attribute outside this function, right?
There was a problem hiding this comment.
I was originally using it for the warning message in case the dataElement wasn't found.
Something like this: Cannot get child (${childPrefix}) dataElement or dataValue for parent dataElement: ${de.id}-${de.name}
But I think this should be enough
Cannot get child dataElement or dataValue for parent dataElement: ${de.id}-${de.name}
I removed this unused attribute. Thank you, Eduardo!
📌 References
📝 Implementation
X.1XORX.2check in step 3📹 Screenshots/Screen capture
2025-09-29.19-48-20.mp4
🔥 Notes to the tester