Feature/manual issue #73
Conversation
BundleMonNo change in files bundle size Groups added (1)
Final result: ✅ View report in BundleMon website ➡️ |
eperedo
left a comment
eperedo
left a comment
There was a problem hiding this comment.
[code-review] Thanks for the code @gqcorneby, looks good, just minor things.
| execute(options: CreateIssueUseCaseOptions): FutureData<Maybe<QualityAnalysis>> { | ||
| const { qualityAnalysisId, sectionId, issues } = options; | ||
|
|
||
| if (issues.length <= 0) return Future.success(undefined); |
There was a problem hiding this comment.
Not need to change, just a mention we have a Future.void() method which is equivalent to Futures.success(undefined)
| api={api} | ||
| onChange={updateForm("orgUnitPaths")} | ||
| selected={addIssueForm.orgUnitPaths} | ||
| levels={[1, 2, 3]} |
There was a problem hiding this comment.
can we extract the levels and selectableLevels values into a constant and reuse it. Right now we have 3 different components where we're using these values (CountrySelector.tsx and ConfigurationForm.tsx)
| } | ||
|
|
||
| function cartesianProduct<T>(arrays: T[][]): T[][] { | ||
| return arrays.reduce<T[][]>((acc, curr) => acc.flatMap(a => curr.map(c => [...a, c])), [[]]); |
There was a problem hiding this comment.
We have an implementation for cartesian in Collection.ts, if we're using this because a particular reason or limitation could you maybe add some comment with the reason?
There was a problem hiding this comment.
Oh! I didn't see it there. Thanks, will use it.
| period, | ||
| categoryOptionComboId: categoryOption, | ||
| countryId: orgUnit, | ||
| description: description || "", |
There was a problem hiding this comment.
No need to change, but I think description could be just string since we're adding an empty string as a fallback?
type AddIssueForm = {
// ...
description: string;
};
Ramon-Jimenez
left a comment
Ramon-Jimenez
left a comment
There was a problem hiding this comment.
Thanks @gqcorneby , it looks really great. Just an adjustments I think we should do:
- If you select a region (e.g. AFR), it should allow you to select and create Manual issues for any country within such region, or for the region itself. Right now, it only allows you to create the issue for the region (or empty), but not for the countries included in such region.
|
Hi @Ramon-Jimenez! I had to update d2-ui-components to 2.10.1 so I can manually set the children as selectable. I just realized that the step summary in the home page will always either be gray or red for Manual Issues. Just wanted to confirm if there's a specific trigger where this step is set to "success". 
|
Ramon-Jimenez
left a comment
Ramon-Jimenez
left a comment
There was a problem hiding this comment.
Thanks @gqcorneby ! It looks and works great overall.
📌 References
📝 Implementation
📹 Screenshots/Screen capture
2025-08-05.13-14-36.mp4
2025-08-05.13-17-25.mp4
🔥 Notes to the tester